fix(azure-iot-device): fix issues where token wouldn't refresh if sto…

…p() was called previously (#1051) * fix(azure-iot-device): fix issues where token wouldn't refresh if stop() was called previously * fix typo
Azure · Oct 12, 2021 · b9c0eeb · b9c0eeb
1 parent 29c9957
commit b9c0eeb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/device/core/src/device_client.ts b/device/core/src/device_client.ts
@@ -91,7 +91,7 @@ export class Client extends InternalClient {
       if (err) {
         debugErrors('transport disconnect event: ' + err);
       } else {
-        debug('transport disconenct event: no error');
+        debug('transport disconnect event: no error');
       }
       if (err && this._retryPolicy.shouldRetry(err)) {
         debugErrors('reconnect policy specifies a reconnect on error');

diff --git a/device/core/src/sak_authentication_provider.ts b/device/core/src/sak_authentication_provider.ts
@@ -107,6 +107,7 @@ export class SharedAccessKeyAuthenticationProvider extends EventEmitter implemen
     if (this._renewalTimeout) {
       clearTimeout(this._renewalTimeout);
       this._renewalTimeout = null;
+      this._currentTokenExpiryTimeInSeconds = undefined;
     }
   }
 

diff --git a/device/core/test/_sak_authentication_provider_test.js b/device/core/test/_sak_authentication_provider_test.js
@@ -244,6 +244,21 @@ describe('SharedAccessKeyAuthenticationProvider', function () {
         sakAuthProvider.stop();
       });
     });
+
+    it('clears _currentTokenExpiryTimeInSeconds so that _shouldRenewToken returns true', async function () {
+      const fakeCredentials = {
+        deviceId: 'fakeDeviceId',
+        host: 'fake.host.name',
+        sharedAccessKey: 'fakeKey'
+      };
+      const sakAuthProvider = new SharedAccessKeyAuthenticationProvider(fakeCredentials, 10, 1);
+      await sakAuthProvider.getDeviceCredentials();
+      assert.isFalse(isNaN(sakAuthProvider._currentTokenExpiryTimeInSeconds), 'isNaN() returned true when it should have been false');
+      assert.isFalse(sakAuthProvider._shouldRenewToken(), '_shouldRenewToken() returned true when it should have been false');
+      sakAuthProvider.stop();
+      assert.isTrue(isNaN(sakAuthProvider._currentTokenExpiryTimeInSeconds), 'isNaN() returned false when it should have been true');
+      assert.isTrue(sakAuthProvider._shouldRenewToken(), '_shouldRenewToken() returned false when it should have been true');
+    });
   });
 
   describe('setTokenRenewalValues', function () {