-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples in TypeScript #1039
Samples in TypeScript #1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might need to rerun lerna bootstrap --hoist to change the package-lock.json files. This will not affect anything on your side, since package-lock.json is only used for npm ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
devdoc
folder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Need examples in TypeScript
Description of the solution
samples/javascript
directorysamples/typescript
directoryjavascript
directoryI will be added more ts files, but wanted to get something out into the main repo before the PR got too large