Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples in TypeScript #1039

Merged
merged 16 commits into from
Sep 29, 2021
Merged

Samples in TypeScript #1039

merged 16 commits into from
Sep 29, 2021

Conversation

danhellem
Copy link
Contributor

@danhellem danhellem commented Sep 28, 2021

Checklist

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Need examples in TypeScript

Description of the solution

  1. created samples/javascript directory
  2. created samples/typescript directory
  3. moved existing javascript files to javascript directory
  4. copied some of the .js samples and converted them into .ts files. Updated coded.
  5. Updated readme.md files to match new structure

I will be added more ts files, but wanted to get something out into the main repo before the PR got too large

Copy link
Contributor

@YoDaMa YoDaMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might need to rerun lerna bootstrap --hoist to change the package-lock.json files. This will not affect anything on your side, since package-lock.json is only used for npm ci

package.json Outdated Show resolved Hide resolved
Copy link
Member

@vishnureddy17 vishnureddy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhellem danhellem merged commit 5450e7a into master Sep 29, 2021
@danhellem danhellem deleted the samples-typescript branch September 29, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants