Fix memory leak in parson's parse_object_value() #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
force-pushed
the
fix-memleak-parson
branch
from
f42d339
to
5b1651e
Compare
MariusNi
approved these changes
Nov 13, 2024
robertwoj-microsoft
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a memory leak in parson by adding a missing free in parson's
parse_object_valueimplementation. The leak is triggerable from our code through fuzzing and we bundle parson so we're responsible for fixing issues in it.get_quoted_stringreturns an allocated string and all other branches in the loop contain the call toparson_free(which isfreeby default). This fix is based on how upstream parson implemented the bugfix: kgabis/parson@ab7f5e5.Checklist
mainbranch prior to this PR submission.mainbranch.