moduletest: add --config option #811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows testing with varous osconfig.json and will remove need for file copy into /etc/ Signed-off-by: Krzysztof Kanas <[email protected]>
MariusNi
reviewed
Nov 15, 2024
| @@ -6,7 +6,7 @@ | |||
| #include <math.h> | |||
|
|
|||
| #define DEFAULT_BIN_PATH "/usr/lib/osconfig" | |||
| #define OSCONFIG_CONFIG_FILE "/etc/osconfig/osconfig.json" | |||
| #define DEFAULT_OSCONFIG_CONFIG_FILE "/etc/osconfig/osconfig.json" | |||
MariusNi
reviewed
Nov 15, 2024
| @@ -56,7 +51,7 @@ jobs: | |||
|
|
|||
| echo -n "testing $name ... " | |||
|
|
|||
| if output=$(sudo ./moduletest $recipe --bin ../bin); then | |||
| if output=$(sudo ./moduletest $recipe --bin ../bin --config ../../src/adapters/pnp/daemon/osconfig.json ); then | |||
There was a problem hiding this comment.
|
This would really help me as a reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows testing with varous osconfig.json and will remove need for file copy into /etc/
Description
Describe your changes in as much detail as possible. Provide a link/reference to the issue solved with this request if any.
Checklist
mainbranch prior to this PR submission.mainbranch.