Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add warning message for DefaultAction value change #10775

Merged
merged 2 commits into from
Dec 25, 2019

Conversation

blueww
Copy link
Member

@blueww blueww commented Dec 24, 2019

Description

The change request is raised in #9880
Have raised PR for this before #10396, but the PR was rejected since not add warning message for breaking before.

So this PR to add warning message, and we will fix it in the next major release.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

msJinLei
msJinLei previously approved these changes Dec 25, 2019
@msJinLei msJinLei dismissed their stale review December 25, 2019 06:55

request a change

@msJinLei msJinLei dismissed their stale review December 25, 2019 06:56

wrong click

@msJinLei
Copy link
Contributor

@blueww Please refer to the link provided and change your breaking change notification format.

@blueww
Copy link
Member Author

blueww commented Dec 25, 2019

@msJinLei
I have fixed you comments. Please help to review again.
Thanks!

@msJinLei msJinLei merged commit 3e0270e into Azure:master Dec 25, 2019
@msJinLei
Copy link
Contributor

msJinLei commented Dec 25, 2019

@msJinLei
I have fixed you comments. Please help to review again.
Thanks!
@blueww
Breaking change release will be in next Friday. You change is to be released at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants