-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch cert cmdlets (not for 0.9.9 release) #1079
Conversation
Incorporate code review comments.
Hi @jasper-schneider, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
||
public System.DateTime? EndTime | ||
{ | ||
get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: better to have on one line
public System.DateTime? EndTime { get { return this.omObject.EndTime; } }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is autogenerated. I can see if there's a flag for line spacing preferences, but I'm not sure what CodeDom offers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not really seeing any options for output formatting when defining properties: https://msdn.microsoft.com/en-us/library/system.codedom.codememberproperty%28v=vs.110%29.aspx
@azuresdkci retest this please |
Batch cert cmdlets (not for 0.9.9 release)
New cmdlets for working with Batch certs.
I'm not aiming for the 0.9.9 release due tomorrow. The next release is fine.