Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update New-AzScheduledQueryRuleLogMetricTrigger.md #10931

Merged
merged 6 commits into from
Mar 7, 2020
Merged

Update New-AzScheduledQueryRuleLogMetricTrigger.md #10931

merged 6 commits into from
Mar 7, 2020

Conversation

theheatDK
Copy link
Contributor

@theheatDK theheatDK commented Jan 17, 2020 •
edited
Loading

Added allowed values for the -MetricTriggerType parameter

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

isra-fel
isra-fel previously approved these changes Jan 20, 2020
View reviewed changes
@isra-fel isra-fel self-assigned this Jan 20, 2020
@isra-fel
Copy link
Member

Hi @theheatDK thanks for the contribution!
@gucalder could you please review this document change?

@isra-fel isra-fel assigned gucalder and unassigned isra-fel Jan 20, 2020
@theheatDK theheatDK closed this Feb 9, 2020
@theheatDK theheatDK reopened this Feb 18, 2020
@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Mar 4, 2020

/azp run azure-powershell - powershell-core

@isra-fel isra-fel assigned isra-fel and unassigned gucalder Mar 4, 2020
@isra-fel
Copy link
Member

isra-fel commented Mar 6, 2020

/azp run azure-powershell - powershell-core

1 similar comment
@isra-fel
Copy link
Member

isra-fel commented Mar 7, 2020

/azp run azure-powershell - powershell-core

@isra-fel isra-fel merged commit df5c057 into Azure:master Mar 7, 2020
@theheatDK theheatDK deleted the patch-9 branch March 7, 2020 07:19
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#10931 from theheatDK/patch-9
879477b 
Update New-AzScheduledQueryRuleLogMetricTrigger.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@isra-fel isra-fel isra-fel left review comments

@gucalder gucalder Awaiting requested review from gucalder

Assignees

@isra-fel isra-fel

Labels
Monitor Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theheatDK @isra-fel @VeryEarly @gucalder