Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimal Tls Version Optional Parameter for SQLDB/MI #11229

Merged
merged 18 commits into from
Mar 4, 2020

Conversation

ziwa-msft
Copy link
Contributor

@ziwa-msft ziwa-msft commented Mar 3, 2020

Description

Added optional Parameter for MinimalTlsVersion property for create/update SQL DB and MI APIs.

This change is intended for S166 for Microsoft JEDI milestone.

Checklist

  • [ x] I have read the Submitting Changes section of CONTRIBUTING.md
  • [x ] The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [ x] The PR does not introduce breaking changes
  • [x ] If applicable, the changes made in the PR have proper test coverage
  • [x ] For public API changes to cmdlets:
    • [x ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • [ x] the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

isra-fel commented Mar 3, 2020

Hi @ziwa-msft the conflicts are blocking the CI. Could you please resolve them?

@ziwa-msft
Copy link
Contributor Author

Hi @ziwa-msft the conflicts are blocking the CI. Could you please resolve them?

Just merged. Thanks

@wyunchi-ms
Copy link
Contributor

Hi @ziwa-msft , could you please update the Upcoming Release section in changelog.md?

@wyunchi-ms
Copy link
Contributor

Please also update the changelog.md for Az.Network. @ziwa-msft

@ziwa-msft ziwa-msft changed the base branch from master to release-2020-03-10 March 4, 2020 06:46
@wyunchi-ms wyunchi-ms merged commit a9ee527 into Azure:release-2020-03-10 Mar 4, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Add Minimal Tls Version Optional Parameter for SQLDB/MI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants