Pass auth headers for virtualHubVnetConnection support across different tenants

[nagula-ritvika]

Description

The VirtualHubVnetConnection resource uses VnetPeering in its underlying implementation. To support peering a vnet to a hub across different tenants, we need to pass auxiliary authorization headers. These headers are not being passed due to a code bug.

Updated the cmdlets New-AzVirtualHubVnetConnection and Update-AzVirtualHubVnetConnection to pass the required headers.

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[adxsdkps]

Can one of the admins verify this patch?

[dedhar]

                this.CreateOrUpdateVirtualHub(this.ResourceGroupName, this.ParentResourceName, parentVirtualHub, parentVirtualHub.Tag, auxAuthHeader);

----- What happens if auxAuthHeader is null? do you want to initialize to empty dictionary

[dedhar]

Do you have to fix Update hub also? Can update or create hub ever pass hub vnet connection in the input request and hit same issue

[nagula-ritvika]

                this.CreateOrUpdateVirtualHub(this.ResourceGroupName, this.ParentResourceName, parentVirtualHub, parentVirtualHub.Tag, auxAuthHeader);

----- What happens if auxAuthHeader is null? do you want to initialize to empty dictionary

If the auth header is null then the code calls the CreateORUpdate method which internally takes cares of the empty dictionary.

[nagula-ritvika]

Do you have to fix Update hub also? Can update or create hub ever pass hub vnet connection in the input request and hit same issue

yup, you were right. updated the hub cmdlets also.

[isra-fel]

LGTM generally. Please follow the requirement in the PR's description to add a changelog entry. Thanks!

[dedhar]

Changes look good to me. Signing off from vWAN Team

[isra-fel]

/azp run azure-powershell - powershell-core

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nagula-ritvika]

Hi, can someone start the build again please

[isra-fel]

/azp run azure-powershell - powershell-core

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).