-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass auth headers for virtualHubVnetConnection support across different tenants #11237
Pass auth headers for virtualHubVnetConnection support across different tenants #11237
Conversation
Can one of the admins verify this patch? |
----- What happens if auxAuthHeader is null? do you want to initialize to empty dictionary |
Do you have to fix Update hub also? Can update or create hub ever pass hub vnet connection in the input request and hit same issue |
If the auth header is null then the code calls the CreateORUpdate method which internally takes cares of the empty dictionary. |
yup, you were right. updated the hub cmdlets also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally. Please follow the requirement in the PR's description to add a changelog entry. Thanks!
Changes look good to me. Signing off from vWAN Team |
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, can someone start the build again please |
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
…ubVnetConn Pass auth headers for virtualHubVnetConnection support across different tenants
Description
The VirtualHubVnetConnection resource uses VnetPeering in its underlying implementation. To support peering a vnet to a hub across different tenants, we need to pass auxiliary authorization headers. These headers are not being passed due to a code bug.
Updated the cmdlets New-AzVirtualHubVnetConnection and Update-AzVirtualHubVnetConnection to pass the required headers.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added