Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New-AzNetworkInterface.md #11348

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Update New-AzNetworkInterface.md #11348

merged 2 commits into from
Mar 24, 2020

Conversation

thomast1906
Copy link
Contributor

@thomast1906 thomast1906 commented Mar 17, 2020

Removed reference to the manual subnet entry and added code to allow retrieval of subnetID via PowerShell from Virtual Network.

This would be a best practice rather than hard-coding subnet ID entry.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Removed reference to the manual subnet entry and added code to allow retrieval of subnetID via PowerShell from Virtual Network.

This would be a best practice rather than hard-coding subnet ID entry.
@isra-fel isra-fel self-assigned this Mar 18, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomast1906 Thank you for the contribution 😀
@avijitgupta or @chandrasekarsrinivasan could you help review this doc update? Thanks.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel merged commit d8f9bb9 into Azure:master Mar 24, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Update New-AzNetworkInterface.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants