Added support for retry policy update for failed items #11359
Conversation
|
Can one of the admins verify this patch? |
sambitratha
force-pushed
the
users/sarath/modify-policy
branch
from
7ce9ef4
to
6574265
Compare
| [Parameter(Position = 1, Mandatory = true, HelpMessage = ParamHelpMsgs.Policy.ProtectionPolicy, | ||
| ValueFromPipeline = true)] | ||
| ValueFromPipeline = true, ParameterSetName = ModifyPolicyParamSet)] | ||
| [Parameter(Position = 1, Mandatory = true, HelpMessage = ParamHelpMsgs.Policy.ProtectionPolicy, | ||
| ValueFromPipeline = true, ParameterSetName = FixInconsistentPolicyParamSet)] |
There was a problem hiding this comment.
If the parameter appears in all the parameter sets, you don't have to specify it twice. In fact, the attribute can remain unchanged.
There was a problem hiding this comment.
In that case can i remove both parameter sets and instead just write Parameter(mandatory=true) ?
There was a problem hiding this comment.
And if it's allowed to do so, making changes in existing parametersets, will it be considered as a breaking change?
There was a problem hiding this comment.
Yes, by omitting the ParameterSetName = *** you are telling powershell that every parameter sets owns it.
It's not changing existing param set, so is not a breaking change.
| /// <summary> | ||
| /// Retry Policy Update for Failed Items | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, HelpMessage = ParamHelpMsgs.Policy.FixForInConsistentItems, |
There was a problem hiding this comment.
I think this switch parameter is mandatory in this parameter set, right?
There was a problem hiding this comment.
And ValidateNotNullOrEmpty won't be necessary
There was a problem hiding this comment.
Besides, since you are changing the cmdlet surface, please regenerate help document.
There was a problem hiding this comment.
Yes, will do the changes
sambitratha
assigned abhipsaMisra and isra-fel and unassigned sambitratha and abhipsaMisra
Added support for retry policy update for failed items
Added a parameter to specify whether or not to retry policy update for failed items.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added