Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CosmosDB] Allow Account creation with ApiKind in Cassandra, Gremlin, Table + Bug Fixes #11388

Merged
merged 7 commits into from
Mar 23, 2020
Merged

[CosmosDB] Allow Account creation with ApiKind in Cassandra, Gremlin, Table + Bug Fixes #11388

merged 7 commits into from
Mar 23, 2020

Conversation

MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented Mar 21, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@MehaKaushik MehaKaushik mentioned this pull request Mar 22, 2020
Closed
@MehaKaushik MehaKaushik changed the title [CosmosDB] Allow Account creation with ApiKind in Cassandra, Gremlin, Table [CosmosDB] Allow Account creation with ApiKind in Cassandra, Gremlin, Table + Bug Fixes Mar 22, 2020
This was referenced Mar 22, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MehaKaushik MehaKaushik added this to the S167 (2020-03-31) milestone Mar 22, 2020
@isra-fel isra-fel self-assigned this Mar 23, 2020
isra-fel
isra-fel approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 2e7ac09 into Azure:master Mar 23, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#11388 from MehaKaushik/20200317
3d56c74 
[CosmosDB] Allow Account creation with ApiKind in Cassandra, Gremlin, Table + Bug Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
needs-review
Projects
None yet
Milestone
S167 (2020-03-31)
Development

Successfully merging this pull request may close these issues.
2 participants
@MehaKaushik @isra-fel