Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add breaking notice for File cmdlets #11493

Merged
merged 2 commits into from
Apr 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Storage/Storage.Management/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Add breaking change notice for Azure File cmdlets output change in a future release
* Support new SkuName StandardGZRS, StandardRAGZRS when create/update Storage account
- New-AzStorageAccount
- Set-AzStorageAccount
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/GetAzureStorageFile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
using Microsoft.Azure.Storage;
using Microsoft.Azure.Storage.File;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Globalization;
using System.Management.Automation;
using System.Net;

[Cmdlet("Get", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFile", DefaultParameterSetName = Constants.ShareNameParameterSetName)]
[OutputType(typeof(CloudFile))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class GetAzureStorageFile : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/GetAzureStorageFileContent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
using LocalDirectory = System.IO.Directory;
using LocalPath = System.IO.Path;
using System.Runtime.InteropServices;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("Get", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFileContent", SupportsShouldProcess = true, DefaultParameterSetName = LocalConstants.ShareNameParameterSetName)]
[OutputType(typeof(CloudFile))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class GetAzureStorageFileContent : StorageFileDataManagementCmdletBase, IDynamicParameters
{
[Parameter(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@
using System.Security.Permissions;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
[Cmdlet("Get", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFileCopyState")]
[OutputType(typeof(CloudFile))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class GetAzureStorageFileCopyStateCommand : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/GetAzureStorageShare.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
using System;
using System.Globalization;
using System.Management.Automation;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("Get", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageShare", DefaultParameterSetName = Constants.MatchingPrefixParameterSetName)]
[OutputType(typeof(CloudFileShare))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFileShare to AzureStorageFileShare, and AzureStorageFileShare will have CloudFileShare as a child property.")]
public class GetAzureStorageShare : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/NewAzureStorageDirectory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
using Microsoft.Azure.Storage.File;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Globalization;
using System.Management.Automation;

[Cmdlet("New", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageDirectory", DefaultParameterSetName = Constants.ShareNameParameterSetName), OutputType(typeof(CloudFileDirectory))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFileDirectory to AzureStorageFileDirectory, and AzureStorageFileDirectory will have CloudFileDirectory as a child property.")]
public class NewAzureStorageDirectory : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/NewAzureStorageShare.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
using System.Management.Automation;
using Azure.Storage.File;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("New", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageShare", DefaultParameterSetName = Constants.ShareNameParameterSetName), OutputType(typeof(CloudFileShare))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFileShare to AzureStorageFileShare, and AzureStorageFileShare will have CloudFileShare as a child property.")]
public class NewAzureStorageShare : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
using Microsoft.Azure.Storage.File;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Globalization;
using System.Management.Automation;

[Cmdlet("Remove", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageDirectory",SupportsShouldProcess = true,DefaultParameterSetName = Constants.ShareNameParameterSetName), OutputType(typeof(CloudFileDirectory))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFileDirectory to AzureStorageFileDirectory, and AzureStorageFileDirectory will have CloudFileDirectory as a child property.")]
public class RemoveAzureStorageDirectory : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/RemoveAzureStorageFile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
using Microsoft.Azure.Storage.File;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Globalization;
using System.Management.Automation;

[Cmdlet("Remove", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFile",SupportsShouldProcess = true,DefaultParameterSetName = Constants.ShareNameParameterSetName), OutputType(typeof(CloudFile))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class RemoveAzureStorageFile : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/RemoveAzureStorageShare.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
using Microsoft.Azure.Storage.File;
using System.Globalization;
using System.Management.Automation;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("Remove", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageShare",DefaultParameterSetName = Constants.ShareNameParameterSetName,SupportsShouldProcess = true), OutputType(typeof(CloudFileShare))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFileShare to AzureStorageFileShare, and AzureStorageFileShare will have CloudFileShare as a child property.")]
public class RemoveAzureStorageShare : AzureStorageFileCmdletBase
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/SetAzureStorageFileContent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
using LocalConstants = Microsoft.WindowsAzure.Commands.Storage.File.Constants;
using System.Runtime.InteropServices;
using Microsoft.Azure.Storage.DataMovement;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("Set", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFileContent", SupportsShouldProcess = true, DefaultParameterSetName = LocalConstants.ShareNameParameterSetName), OutputType(typeof(CloudFile))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class SetAzureStorageFileContent : StorageFileDataManagementCmdletBase, IDynamicParameters
{
[Parameter(
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/SetAzureStorageShareQuota.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
using System.Globalization;
using System.Management.Automation;
using System.Security.Permissions;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
[Cmdlet("Set", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageShareQuota"), OutputType(typeof(FileShareProperties))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from FileShareProperties to AzureStorageFileShare, and AzureStorageFileShare will have FileShareProperties in child property.")]
public class SetAzureStorageShareQuota : AzureStorageFileCmdletBase
{
[Alias("N", "Name")]
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/File/Cmdlet/StartAzureStorageFileCopy.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
using System.Management.Automation;
using System.Security.Permissions;
using System.Threading.Tasks;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet
{
[Cmdlet("Start", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageFileCopy", SupportsShouldProcess = true), OutputType(typeof(void))]
[CmdletOutputBreakingChange(typeof(CloudFile), ChangeDescription = "The output type will change from CloudFile to AzureStorageFile, and AzureStorageFile will have CloudFile as a child property.")]
public class StartAzureStorageFileCopyCommand : StorageFileDataManagementCmdletBase
{
private const string ContainerNameParameterSet = "ContainerName";
Expand Down