Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExpressRoute][GlobalReach]Remove-AzExpressRouteCircuitConnectionConfig to have another param AddressPrefixType to remove individual address family configs #12020

Merged
merged 2 commits into from
May 29, 2020

Conversation

amwate
Copy link
Contributor

@amwate amwate commented May 28, 2020

…dressPrefixType to remove the IPv4 or IPv6 configuration.

Description

This PR addresses addition of another parameter AddressPrefixType to the existing Remove-AzExpressRouteCircuitConnectionConfig cmdlet.

The cmdlet to have another parameter for partial removal of the config based on the address family.

If none is specified (as in legacy scenarios), the entire configuration would be removed.
This is to keep it consistent with the earlier behavior.

The design review for the same was addressed as part of
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/601.

This is also an extension of the earlier PR : #11501, where we had introduced the Set-AzExpressRouteCircuitConnectionConfig for the resource.

Checklist

  • [ x] I have read the Submitting Changes section of CONTRIBUTING.md
  • [ x] The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@cormacpayne cormacpayne removed their request for review May 28, 2020 17:45
@cormacpayne
Copy link
Member

@amwate -- I'm no longer a member of the Azure PowerShell team, so I have removed myself as a reviewer for this PR.

@VeryEarly VeryEarly self-assigned this May 29, 2020
@VeryEarly VeryEarly merged commit 4052a2a into Azure:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants