Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNG multi Auth support #14441

Merged
merged 13 commits into from
Mar 10, 2021

Conversation

neethirshetty
Copy link
Contributor

@neethirshetty neethirshetty commented Mar 5, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@neethirshetty neethirshetty changed the title FOR TESTING VNG VNG multi Auth support Mar 6, 2021
@neethirshetty neethirshetty marked this pull request as ready for review March 6, 2021 02:40
@wyunchi-ms
Copy link
Contributor

Please resolve the conflicts and security issue.

@wyunchi-ms
Copy link
Contributor

LGTM

Copy link
Member

@Nilambari Nilambari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 nuget packages added under LocalFeed but its not consumed. If its not needed, remove them.

@wyunchi-ms wyunchi-ms merged commit 00f5bae into Azure:network-november Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants