Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email service data plane operations - Send email and get email send status #25431

Merged

Conversation

v-vprasannak
Copy link
Contributor

@v-vprasannak v-vprasannak commented Jul 2, 2024

Description

Version 0.1.0

  • First preview release for module Az.CommunicationServicesEmail, root module is Az.Communication
    • Added support for Email service data plane operations.
    • Send email and get email send result are the data plane operations.

ChangeLog.md

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Communication
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzCommunicationService Get-AzCommunicationService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCommunicationService Get-AzCommunicationService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailService Get-AzEmailService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailService Get-AzEmailService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServicedataEmailSendResult Get-AzEmailServicedataEmailSendResult Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServicedataEmailSendResult Get-AzEmailServicedataEmailSendResult changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceDomain Get-AzEmailServiceDomain changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzEmailServiceSenderUsername Get-AzEmailServiceSenderUsername changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Communication. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 29.17 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 29.17% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 29.17% Test coverage for the module cannot be lower than 50%.

@VeryEarly VeryEarly self-assigned this Jul 7, 2024
@VeryEarly
Copy link
Contributor

@v-vprasannak
Copy link
Contributor Author

Is this new submodule coresponding dataplane to https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest ?

Yes, its a new module for dataplane

@VeryEarly
Copy link
Contributor

Is this new submodule coresponding dataplane to https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest ?

Yes, its a new module for dataplane

I mean is https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest related to these dataplane API? Are they the same resource?

@v-vprasannak
Copy link
Contributor Author

Is this new submodule coresponding dataplane to https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest ?

Yes, its a new module for dataplane

I mean is https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest related to these dataplane API? Are they the same resource?

https://github.com/Azure/azure-powershell/tree/generation/src/Communication/EmailService.Autorest is the control plane module for Email Communication services. and this PR is for data plane module for Email Communication Services. Yes, the same resource.

@VeryEarly
Copy link
Contributor

if so, please update module name to EmailServicedata.Autorest (folder name, 'Title' in README.md) and regenerate

@v-vprasannak
Copy link
Contributor Author

if so, please update module name to EmailServicedata.Autorest (folder name, 'Title' in README.md) and regenerate

Regenerated the code by updating the folder name and Title in README.md file.

@VeryEarly
Copy link
Contributor

please add/record test to cover these new cmdlets

@v-vprasannak
Copy link
Contributor Author

please add/record test to cover these new cmdlets

Added test scenarios, please review

@VeryEarly VeryEarly merged commit d950ce1 into Azure:generation Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants