[Bastion] Add support for Bastion shareable links #25623

abhi7860 · 2024-07-23T17:48:13Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

Issue: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1428

azure-client-tools-bot-prd · 2024-07-23T17:48:16Z

️✔️Az.Accounts

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

⚠️Az.KeyVault

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

⚠️Az.NetAppFiles

⚠️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

️✔️Az.Sql

️✔️Az.Storage

️✔️Az.Websites

VeryEarly · 2024-07-24T03:21:50Z

Please move changelog to line 22 right under 'upcoming release'

VeryEarly · 2024-07-26T08:49:19Z

/azp run

azure-pipelines · 2024-07-26T08:49:38Z

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s).

YanaXu · 2024-07-26T09:26:31Z

/azp run

azure-pipelines · 2024-07-26T09:26:47Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2024-07-29T10:42:42Z

please fix below example issues:
"Az.Network","Get-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\Get-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","Get-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\Get-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","New-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\New-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","New-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\New-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","Remove-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\Remove-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","Remove-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a_work\1\s\src\Network\Network\help\Remove-AzBastionShareableLink.md","Delete the prompt of example."
"Az.Network","Remove-AzBastionShareableLink","1","4","UnexpectedToken","5200","1","Unexpected token 'Yes' in expression or statement.","Yes","Unexpected Error. Please check Trouble Shotting for Unexpected Errors in Example Issues for more details."
"Az.Network","Remove-AzBastionShareableLink","1","2","Invalid_Cmdlet","5000","1","Confirm is not a valid command name.","Confirm","Check the spell of Confirm."
"Az.Network","Remove-AzBastionShareableLink","1","3","Invalid_Cmdlet","5000","1","Are is not a valid command name.","Are you sure you want to remove Bastion shareable link(s)?","Check the spell of Are."
"Az.Network","Remove-AzBastionShareableLink","1","3","Invalid_Cmdlet","5000","1","s is not a valid command name.","s","Check the spell of s."
"Az.Network","Remove-AzBastionShareableLink","1","4","Capitalization_Conventions_Violated","5101","1","Yes doesn't follow the Capitalization Conventions.","Yes [N] No [S] Suspend [?] Help (default is 'Y'): Y","Check the Capitalization Conventions. Suggest format: yes.exe"
"Az.Network","Remove-AzBastionShareableLink","1","4","Invalid_Cmdlet","5000","1","default is not a valid command name.","default is 'Y'","Check the spell of default."

src/Network/Network.Test/ScenarioTests/BastionTests.ps1

src/Network/Network/Bastion/ShareableLink/GetAzBastionShareableLinkCommand.cs

src/Network/Network/Network.format.ps1xml

src/Network/Network/help/New-AzBastionShareableLink.md

msJinLei · 2024-09-05T19:26:17Z

  Analyzer invoked with parameters: -p D:\a\_work\1\s\artifacts/Debug -r D:\a\_work\1\s\artifacts/StaticAnalysisResults --analyzers check-error
  D:\a\_work\1\s\artifacts/StaticAnalysisResults
  D:\a\_work\1\s\artifacts/StaticAnalysisResults\ExampleIssues.csv Errors
  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.Network","Get-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\Get-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","Get-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\Get-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","New-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\New-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","New-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\New-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","Remove-AzBastionShareableLink","1","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\Remove-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","Remove-AzBastionShareableLink","2","0","NeedDeleting","5050","1","The prompt of example need to be deleted.","D:\a\_work\1\s\src\Network\Network\help\Remove-AzBastionShareableLink.md","Delete the prompt of example."
  "Az.Network","Remove-AzBastionShareableLink","1","4","UnexpectedToken","5200","1","Unexpected token 'Yes' in expression or statement.","Yes","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](https://github.com/Azure/azure-powershell/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.Network","Remove-AzBastionShareableLink","1","2","Invalid_Cmdlet","5000","1","Confirm is not a valid command name.","Confirm","Check the spell of Confirm."
  "Az.Network","Remove-AzBastionShareableLink","1","3","Invalid_Cmdlet","5000","1","Are is not a valid command name.","Are you sure you want to remove Bastion shareable link(s)?","Check the spell of Are."
  "Az.Network","Remove-AzBastionShareableLink","1","3","Invalid_Cmdlet","5000","1","s is not a valid command name.","s","Check the spell of s."
  "Az.Network","Remove-AzBastionShareableLink","1","4","Capitalization_Conventions_Violated","5101","1","Yes doesn't follow the Capitalization Conventions.","Yes  [N] No  [S] Suspend  [?] Help (default is 'Y'): Y","Check the Capitalization Conventions. Suggest format: yes.exe"
  "Az.Network","Remove-AzBastionShareableLink","1","4","Invalid_Cmdlet","5000","1","default is not a valid command name.","default is 'Y'","Check the spell of default."

msJinLei

Please fix the help doc issues

src/Network/Network/help/Remove-AzBastionShareableLink.md

src/Network/Network/help/New-AzBastionShareableLink.md

src/Network/Network/help/Remove-AzBastionShareableLink.md

github-actions · 2024-09-05T19:44:27Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

abhi7860 · 2024-09-06T05:54:30Z

@msJinLei Issues with help docs have been addressed. Can you please review again? Thanks!

msJinLei · 2024-09-06T06:06:06Z

/azp run azure-powershell - security-tools

azure-pipelines · 2024-09-06T06:06:15Z

Azure Pipelines successfully started running 1 pipeline(s).

msJinLei · 2024-09-09T02:31:15Z

/azp run azure-powershell - security-tools

azure-pipelines · 2024-09-09T02:31:24Z

Azure Pipelines successfully started running 1 pipeline(s).

VeryEarly self-assigned this Jul 24, 2024

VeryEarly previously approved these changes Jul 26, 2024

View reviewed changes

VeryEarly dismissed their stale review via 4a68101 July 29, 2024 10:05

msftsijielin approved these changes Jul 30, 2024

View reviewed changes

Abhishek Shah added 10 commits September 5, 2024 10:34

Init

34f9256

Adding help content

e05ec02

Update test run

883dcf3

Null check

ee5c0a6

Update ChangeLog.md

dbf2460

Update help

c56db80

Update test result

94426b8

Minor string changes

f097865

Update ChangeLog.md

17391d8

Updating BSL label

ad8376a

abhi7860 force-pushed the bastion/bsl branch from 5ced257 to ad8376a Compare September 5, 2024 17:38

msJinLei requested changes Sep 5, 2024

View reviewed changes

msJinLei assigned msJinLei and unassigned VeryEarly Sep 5, 2024

msJinLei added the needs-revision label Sep 5, 2024

Abhishek Shah added 2 commits September 5, 2024 15:32

Update help

b1b3589

Update Remove-AzBastionShareableLink.md

04ce8d5

abhi7860 added needs-review ready to review and removed needs-revision labels Sep 6, 2024

abhi7860 requested a review from msJinLei September 6, 2024 05:55

msJinLei previously approved these changes Sep 9, 2024

View reviewed changes

Update ChangeLog.md

30c8e10

msJinLei dismissed their stale review via 30c8e10 September 9, 2024 01:03

msJinLei self-requested a review September 9, 2024 01:04

msJinLei approved these changes Sep 9, 2024

View reviewed changes

msJinLei added Waiting for CI and removed needs-review ready to review labels Sep 9, 2024

msJinLei merged commit 5e792bf into Azure:release-network-2024-03-01 Sep 9, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bastion] Add support for Bastion shareable links #25623

[Bastion] Add support for Bastion shareable links #25623

abhi7860 commented Jul 23, 2024

azure-client-tools-bot-prd bot commented Jul 23, 2024 •

edited

Loading

VeryEarly commented Jul 24, 2024

VeryEarly commented Jul 26, 2024

azure-pipelines bot commented Jul 26, 2024

YanaXu commented Jul 26, 2024

azure-pipelines bot commented Jul 26, 2024

VeryEarly commented Jul 29, 2024

msJinLei commented Sep 5, 2024

msJinLei left a comment

github-actions bot commented Sep 5, 2024

abhi7860 commented Sep 6, 2024

msJinLei commented Sep 6, 2024

azure-pipelines bot commented Sep 6, 2024

msJinLei commented Sep 9, 2024

azure-pipelines bot commented Sep 9, 2024

[Bastion] Add support for Bastion shareable links #25623

[Bastion] Add support for Bastion shareable links #25623

Conversation

abhi7860 commented Jul 23, 2024

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Jul 23, 2024 • edited Loading

VeryEarly commented Jul 24, 2024

VeryEarly commented Jul 26, 2024

azure-pipelines bot commented Jul 26, 2024

YanaXu commented Jul 26, 2024

azure-pipelines bot commented Jul 26, 2024

VeryEarly commented Jul 29, 2024

msJinLei commented Sep 5, 2024

msJinLei left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2024

abhi7860 commented Sep 6, 2024

msJinLei commented Sep 6, 2024

azure-pipelines bot commented Sep 6, 2024

msJinLei commented Sep 9, 2024

azure-pipelines bot commented Sep 9, 2024

azure-client-tools-bot-prd bot commented Jul 23, 2024 •

edited

Loading