-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bastion] Add support for Bastion shareable links #25623
[Bastion] Add support for Bastion shareable links #25623
Conversation
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
⚠️ Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.63 % 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.63% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.63% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.63% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion. ⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -TargetVmId $vm1.Id is a null-valued parameter value. -TargetVmId Assign value for $vm1.Id. ⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -Name $vmName is a null-valued parameter value. -Name Assign value for $vmName. ⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -Name $vmName1 is a null-valued parameter value. -Name Assign value for $vmName1. ⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -Name $vmName2 is a null-valued parameter value. -Name Assign value for $vmName2. ⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ New-AzBastionShareableLink 2 4 Mismatched_Parameter_Value_Type New-AzBastionShareableLink -TargetVmId $vm1.Id, $vm2.Id is not an expected parameter value type. -TargetVmId Use correct parameter value type. Expected Type is string. Now the type is Microsoft.Azure.Commands.Compute.Models.PSVirtualMachineInstanceView.(Command). ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id. ⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion. ⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion. ⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -TargetVmId $vm1.Id is a null-valued parameter value. -TargetVmId Assign value for $vm1.Id. ⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -Name $vmName is a null-valued parameter value. -Name Assign value for $vmName. ⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -Name $vmName1 is a null-valued parameter value. -Name Assign value for $vmName1. ⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -Name $vmName2 is a null-valued parameter value. -Name Assign value for $vmName2. ⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ New-AzBastionShareableLink 2 4 Mismatched_Parameter_Value_Type New-AzBastionShareableLink -TargetVmId $vm1.Id, $vm2.Id is not an expected parameter value type. -TargetVmId Use correct parameter value type. Expected Type is string. Now the type is Microsoft.Azure.Commands.Compute.Models.PSVirtualMachineInstanceView.(Command). ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName. ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName. ⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id. ⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion. ⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Please move changelog to line 22 right under 'upcoming release' |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
please fix below example issues: |
src/Network/Network/Bastion/ShareableLink/GetAzBastionShareableLinkCommand.cs
Show resolved
Hide resolved
5ced257
to
ad8376a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the help doc issues
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@msJinLei Issues with help docs have been addressed. Can you please review again? Thanks! |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.Issue: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1428