-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RecoveryServices.Backup] Added support for enabling Disk access settings for managed VM restores #25663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.Network
|
Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
---|---|---|---|---|---|---|---|
Restore-AzRecoveryServicesBackupItem | 7 | 8 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. | -WLRecoveryConfig | Assign value for $AnotherInstanceWithLogConfig. | |
Restore-AzRecoveryServicesBackupItem | 9 | 4 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. | -RestoreDiskList | Assign value for $restoreDiskLUNs. | |
Restore-AzRecoveryServicesBackupItem | 12 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. | -Item | Assign value for $item. |
⚠️ Windows PowerShell - Windows
Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
---|---|---|---|---|---|---|---|
Restore-AzRecoveryServicesBackupItem | 7 | 8 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. | -WLRecoveryConfig | Assign value for $AnotherInstanceWithLogConfig. | |
Restore-AzRecoveryServicesBackupItem | 9 | 4 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. | -RestoreDiskList | Assign value for $restoreDiskLUNs. | |
Restore-AzRecoveryServicesBackupItem | 12 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. | -Item | Assign value for $item. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
VeryEarly
previously approved these changes
Jul 28, 2024
VeryEarly
reviewed
Jul 28, 2024
@@ -21,6 +21,7 @@ | |||
|
|||
## Version 7.0.0 | |||
* [Breaking Change] Renamed the property `ResouceType` of `ASRVaultSettings` to `ResourceType`. | |||
* Added support for enabling Disk access settings for managed VM restores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this line to line 21 under upcoming release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
approved these changes
Jul 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
…ings for managed VM restores (#25663) * Added support for enabling Disk access settings for managed VM restores Updated help * updated changelog
6 tasks
VeryEarly
added a commit
that referenced
this pull request
Aug 6, 2024
…ings for managed VM restores (#25663) (#25750) * Added support for enabling Disk access settings for managed VM restores Updated help * updated changelog Co-authored-by: Himanshu Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for enabling Disk access settings for managed VM restores
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.