Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RecoveryServices.Backup] Added support for enabling Disk access settings for managed VM restores #25663

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Jul 26, 2024

Description

Added support for enabling Disk access settings for managed VM restores

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jul 26, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Restore-AzRecoveryServicesBackupItem 7 8 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. -WLRecoveryConfig Assign value for $AnotherInstanceWithLogConfig.
⚠️ Restore-AzRecoveryServicesBackupItem 9 4 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. -RestoreDiskList Assign value for $restoreDiskLUNs.
⚠️ Restore-AzRecoveryServicesBackupItem 12 3 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. -Item Assign value for $item.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Restore-AzRecoveryServicesBackupItem 7 8 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. -WLRecoveryConfig Assign value for $AnotherInstanceWithLogConfig.
⚠️ Restore-AzRecoveryServicesBackupItem 9 4 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. -RestoreDiskList Assign value for $restoreDiskLUNs.
⚠️ Restore-AzRecoveryServicesBackupItem 12 3 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. -Item Assign value for $item.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

VeryEarly
VeryEarly previously approved these changes Jul 28, 2024
@@ -21,6 +21,7 @@

## Version 7.0.0
* [Breaking Change] Renamed the property `ResouceType` of `ASRVaultSettings` to `ResourceType`.
* Added support for enabling Disk access settings for managed VM restores.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this line to line 21 under upcoming release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@VeryEarly VeryEarly dismissed their stale review July 28, 2024 12:44

not approved

@VeryEarly
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly merged commit 876e048 into Azure:main Jul 29, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
…ings for managed VM restores (#25663)

* Added support for enabling Disk access settings for managed VM restores
Updated help

* updated changelog
VeryEarly added a commit that referenced this pull request Aug 6, 2024
…ings for managed VM restores (#25663) (#25750)

* Added support for enabling Disk access settings for managed VM restores
Updated help

* updated changelog

Co-authored-by: Himanshu Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants