-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] Add 'AuthenticationMetadata' option to New and Set AzSqlInstance cmdlets #25700
Merged
dolauli
merged 7 commits into
Azure:main
from
krivi37:krivi37/addAuthenticationMetadataForManagedInstance
Aug 2, 2024
Merged
[SQL] Add 'AuthenticationMetadata' option to New and Set AzSqlInstance cmdlets #25700
dolauli
merged 7 commits into
Azure:main
from
krivi37:krivi37/addAuthenticationMetadataForManagedInstance
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Sql
️✔️Az.Storage
|
dolauli
requested changes
Jul 31, 2024
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
dolauli
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds option to configure which metadata should be used for authenticating users which were synced from on-prem Active Directory domains. The authentication metadata has 3 options:
AzureAD
,Paired
andWindows
.These options dictate which metadata in managed instance will be used for on-prem synced users for authentication:
AzureAD
- all on-prem synced users must have Microsoft Entra (AAD) logins/users present in metadata in order to be able to login to the managed instance.Paired
- on-prem synced users will use metadata depending on the type of the authentication they use. If they try to connect using Microsoft Entra authentication, then they must have Microsoft Entra logins/users. In case they try to connect using Windows authentication, they must have Windows logins/users present in the metadata.Windows
- all on-prem synced users must have Windows logins/users present in metadata in order to be able to login to the managed instance.These options are exposed by adding
AuthenticationMetadata
option to theNew-AzSqlInstance
andSet-AzSqlInstance
cmdlets.The default authentication metadata option is
AzureAD
.For more information, please refer to: https://learn.microsoft.com/en-us/azure/azure-sql/managed-instance/native-windows-principals?view=azuresql
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.