[Compute] Adding ResourceIdsOnly to Get-AzCapacityReservationGroup #25703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haagha
requested review from
bilaakpan-ms,
Sandido and
grizzlytheodore
as code owners
️✔️Az.Accounts
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Get-AzCapacityReservationGroup | 1 | 1 | Unassigned_Variable | Get-AzCapacityReservationGroup -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| Get-AzCapacityReservationGroup | 2 | 1 | Unassigned_Variable | Get-AzCapacityReservationGroup -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Get-AzCapacityReservationGroup | 1 | 1 | Unassigned_Variable | Get-AzCapacityReservationGroup -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| Get-AzCapacityReservationGroup | 2 | 1 | Unassigned_Variable | Get-AzCapacityReservationGroup -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
grizzlytheodore
previously approved these changes
Aug 1, 2024
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@haagha I made a change to mask the password in the test to avoid security failures. Please review whether the change is OK for you. An potential impact of the change is that next time when you record the test, you may need to unmask the password for recording test and re-mask the password afterward. |
|
@haagha Would you please resolve the conflict? |
|
@dolauli looks good. |
dolauli
approved these changes
Aug 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…25703) * changes * Update ChangeLog.md * removing passwords * Update VirtualMachineTests.ps1 to mask password --------- Co-authored-by: Xiaogang <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Aug 19, 2024
…25703) (#25849) * changes * Update ChangeLog.md * removing passwords * Update VirtualMachineTests.ps1 to mask password --------- Co-authored-by: Haider Agha <[email protected]> Co-authored-by: Xiaogang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1420
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.