-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 28957665: Fixed psObject List Enumeration #25781
Bug 28957665: Fixed psObject List Enumeration #25781
Conversation
️✔️Az.Accounts
️✔️Az.Maintenance
|
Hi @notyashhh,
|
src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.ps1
Outdated
Show resolved
Hide resolved
src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.ps1
Outdated
Show resolved
Hide resolved
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-powershell - security-tools |
Commenter does not have sufficient privileges for PR 25781 in repo Azure/azure-powershell |
1 similar comment
Commenter does not have sufficient privileges for PR 25781 in repo Azure/azure-powershell |
I think maybe we need two configurations in the test cases to check if the list will be unpacking as single enumeration |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@notyashhh, if your PR is ready for reviewing again, add needs-review label. |
…ub.com:notyashhh/azure-powershell into fix/28957665-Update-AzMaintenanceConfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Looks good to me.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Fix the security pipeline failure.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
* Fixed psObject List Enumeration * Added test case: UpdateConfig cmdlet * Updated Changelog * Additioanl Test Case + Updated Changelog * Added complex test case: Multiple Configs * Update NuGet.Config Fix the security pipeline failure. * revert nuget.config changes, test whether cached upstream works * Update NuGet.Config * Update NuGet.Config --------- Co-authored-by: Yash Patil <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yabo Hu <[email protected]>
* Fixed psObject List Enumeration * Added test case: UpdateConfig cmdlet * Updated Changelog * Additioanl Test Case + Updated Changelog * Added complex test case: Multiple Configs * Update NuGet.Config Fix the security pipeline failure. * revert nuget.config changes, test whether cached upstream works * Update NuGet.Config * Update NuGet.Config --------- Co-authored-by: Yash <[email protected]> Co-authored-by: Yash Patil <[email protected]> Co-authored-by: Xiaogang <[email protected]>
Problem Description:
Cannot convert 'Microsoft.Azure.Commands.Maintenance.Models.PSMaintenanceConfiguration' to the type 'Microsoft.Azure.Commands.Maintenance.Models.PSMaintenanceConfiguration' required by parameter 'Configuration'. Specified method is not supported.
This issue occurred when Get-AzMaintenanceConfiguration was called without the ResourceGroupName parameter, causing the returned object to be of type List, instead of a single PSMaintenanceConfiguration.
Fix Implemented:
Verification:
Added test cases to cover both scenarios ensuring the command operates as expected.
Issue Addressed:
Testing:
Impact:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.