Bug 28957665: Fixed psObject List Enumeration #25781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Maintenance
|
|
Hi @notyashhh,
|
BethanyZhou
requested changes
Aug 7, 2024
src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.ps1
Outdated
Show resolved
Hide resolved
BethanyZhou
requested changes
Aug 8, 2024
src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.ps1
Outdated
Show resolved
Hide resolved
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Commenter does not have sufficient privileges for PR 25781 in repo Azure/azure-powershell |
1 similar comment
|
Commenter does not have sufficient privileges for PR 25781 in repo Azure/azure-powershell |
|
I think maybe we need two configurations in the test cases to check if the list will be unpacking as single enumeration |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
@notyashhh, if your PR is ready for reviewing again, add needs-review label. |
added 2 commits
August 12, 2024 15:10
…ub.com:notyashhh/azure-powershell into fix/28957665-Update-AzMaintenanceConfiguration
BethanyZhou
previously approved these changes
Aug 13, 2024
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix the security pipeline failure.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dolauli
approved these changes
Aug 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Fixed psObject List Enumeration * Added test case: UpdateConfig cmdlet * Updated Changelog * Additioanl Test Case + Updated Changelog * Added complex test case: Multiple Configs * Update NuGet.Config Fix the security pipeline failure. * revert nuget.config changes, test whether cached upstream works * Update NuGet.Config * Update NuGet.Config --------- Co-authored-by: Yash Patil <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yabo Hu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Aug 19, 2024
* Fixed psObject List Enumeration * Added test case: UpdateConfig cmdlet * Updated Changelog * Additioanl Test Case + Updated Changelog * Added complex test case: Multiple Configs * Update NuGet.Config Fix the security pipeline failure. * revert nuget.config changes, test whether cached upstream works * Update NuGet.Config * Update NuGet.Config --------- Co-authored-by: Yash <[email protected]> Co-authored-by: Yash Patil <[email protected]> Co-authored-by: Xiaogang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
Cannot convert 'Microsoft.Azure.Commands.Maintenance.Models.PSMaintenanceConfiguration' to the type 'Microsoft.Azure.Commands.Maintenance.Models.PSMaintenanceConfiguration' required by parameter 'Configuration'. Specified method is not supported.
This issue occurred when Get-AzMaintenanceConfiguration was called without the ResourceGroupName parameter, causing the returned object to be of type List, instead of a single PSMaintenanceConfiguration.
Fix Implemented:
Verification:
Added test cases to cover both scenarios ensuring the command operates as expected.
Issue Addressed:
Testing:
Impact:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.