-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetAppFiles] Add missing parameter SnapshotName #25837
Conversation
️✔️Az.Accounts
️✔️Az.ManagedServiceIdentity
|
Type | Title | Current Coverage | Last Coverage | Description |
---|---|---|---|---|
Test Coverage Less Than 80% | 77.92 % | 78.87% | Test coverage cannot be lower than the number of the last release. |
⚠️ - MacOS
Type | Title | Current Coverage | Last Coverage | Description |
---|---|---|---|---|
Test Coverage Less Than 80% | 77.92% | 78.87% | Test coverage cannot be lower than the number of the last release. |
⚠️ PowerShell Core - Windows
Type | Title | Current Coverage | Last Coverage | Description |
---|---|---|---|---|
Test Coverage Less Than 80% | 77.92% | 78.87% | Test coverage cannot be lower than the number of the last release. |
⚠️ Windows PowerShell - Windows
Type | Title | Current Coverage | Last Coverage | Description |
---|---|---|---|---|
Test Coverage Less Than 80% | 77.92% | 78.87% | Test coverage cannot be lower than the number of the last release. |
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Fixes customer-reported issue #25791 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required.
src/NetAppFiles/NetAppFiles/help/Approve-AzNetAppFilesReplication.md
Outdated
Show resolved
Hide resolved
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@dolauli PR updated, thanks for your feedback. |
* add snapshotName * add snapshotName not requred * Changelog * revert * snapshotname
Description
Adds missing parameter
SnapshotName
toNew-AzNetAppFilesBackup
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.