[Storage] Refine track2 OAuth context logic #25954

yifanz7 · 2024-08-28T08:43:38Z

Description

Refine #25897

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-08-28T08:43:40Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Compute

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.EventHub

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.IotHub

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

️✔️Az.KeyVault

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Monitor

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Network

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.OperationalInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.PrivateDns

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.RedisCache

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Search

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Sql

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Storage

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️File Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️Az.StorageSync

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00 % 80.00% Test coverage cannot be lower than the number of the last release.

⚠️ - MacOS

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️PowerShell Core - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️Az.Synapse

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

msJinLei · 2024-08-29T03:41:36Z

@yifanz7 the release-2024-09-03 is already code-frozen. could your PR goes into next release?
Please add the change log for the next release

* refine track2 oauth context logic * add changelog --------- Co-authored-by: Jin Lei <[email protected]>

* refine track2 oauth context logic * add changelog --------- Co-authored-by: yifanz7 <[email protected]> Co-authored-by: Jin Lei <[email protected]>

refine track2 oauth context logic

fefdcf6

msJinLei added this to the Az 12.4.0 (October 2024, 2024-10-08) milestone Aug 29, 2024

msJinLei assigned msJinLei and yifanz7 Aug 29, 2024

add changelog

22e1360

msJinLei previously approved these changes Aug 29, 2024

View reviewed changes

msJinLei added the Waiting for CI label Aug 29, 2024

Merge branch 'main' into fixoauthcontext

19d1a8a

msJinLei dismissed their stale review via 19d1a8a August 29, 2024 09:17

msJinLei approved these changes Aug 29, 2024

View reviewed changes

msJinLei merged commit 0a0f8d7 into Azure:main Aug 29, 2024
12 checks passed

github-actions bot pushed a commit that referenced this pull request Aug 29, 2024

[Storage] Refine track2 OAuth context logic (#25954)

5ad2d6a

* refine track2 oauth context logic * add changelog --------- Co-authored-by: Jin Lei <[email protected]>

VeryEarly added a commit that referenced this pull request Sep 2, 2024

[Storage] Refine track2 OAuth context logic (#25954) (#25986)

6db27c2

* refine track2 oauth context logic * add changelog --------- Co-authored-by: yifanz7 <[email protected]> Co-authored-by: Jin Lei <[email protected]>

msJinLei mentioned this pull request Sep 5, 2024

[Storage] Fixed issue that table cmdlet fail with context get from StorageAccount object #26014

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Refine track2 OAuth context logic #25954

[Storage] Refine track2 OAuth context logic #25954

yifanz7 commented Aug 28, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 28, 2024 •

edited

Loading

msJinLei commented Aug 29, 2024 •

edited

Loading

[Storage] Refine track2 OAuth context logic #25954

[Storage] Refine track2 OAuth context logic #25954

Conversation

yifanz7 commented Aug 28, 2024 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Aug 28, 2024 • edited Loading

msJinLei commented Aug 29, 2024 • edited Loading

yifanz7 commented Aug 28, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Aug 28, 2024 •

edited

Loading

msJinLei commented Aug 29, 2024 •

edited

Loading