Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blueprint] Remove Blueprint 0.20.7-preview dependencies on released track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk #26036

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Sep 6, 2024

Description

Remove Microsoft.Azure.Management.Blueprint 0.20.7-preview dependencies
Add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 6, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Blueprint
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 23.08 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@msJinLei
Copy link
Contributor

msJinLei commented Sep 9, 2024

@JoyerJin Do you want this change to be released in the upcoming one? If so, please add changlog. If not, I will just merge it.

@msJinLei msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Sep 9, 2024
@JoyerJin
Copy link
Contributor Author

JoyerJin commented Sep 9, 2024

I am checking whether the testing run successfully on GitHub mock environment. Now the coverage looks like too low, I need to confirm if it has risk.

@microsoft-github-policy-service microsoft-github-policy-service bot added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. labels Sep 9, 2024
@JoyerJin JoyerJin added needs-review and removed needs-team-attention This issue needs attention from Azure service team or SDK team labels Sep 10, 2024
@JoyerJin
Copy link
Contributor Author

Confirmed, no need to add test case.

@msJinLei msJinLei merged commit b819ada into main Sep 13, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
…track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk (#26036)

* blueprint management sdk generated by autorest.csharp

* blueprint management sdk generated by autorest.powershell

* Update Assembly

* Blueprint changelog

* Update ChangeLog.md

---------

Co-authored-by: Jin Lei <[email protected]>
github-actions bot pushed a commit to notyashhh/azure-powershell that referenced this pull request Sep 13, 2024
…track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk (Azure#26036)

* blueprint management sdk generated by autorest.csharp

* blueprint management sdk generated by autorest.powershell

* Update Assembly

* Blueprint changelog

* Update ChangeLog.md

---------

Co-authored-by: Jin Lei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants