-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blueprint] Remove Blueprint 0.20.7-preview dependencies on released track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk #26036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
AssemblyInfo.cs will be updated automatically. Please do not update it manually. | Revert AssemblyInfo.cs to its last version. |
⚠️ Windows PowerShell - Windows
Type | Cmdlet | Description | Remediation |
---|---|---|---|
AssemblyInfo.cs will be updated automatically. Please do not update it manually. | Revert AssemblyInfo.cs to its last version. |
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 23.08 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 23.08% Test coverage for the module cannot be lower than 50%.
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
@JoyerJin Do you want this change to be released in the upcoming one? If so, please add changlog. If not, I will just merge it. |
msJinLei
added
the
needs-author-feedback
More information is needed from author to address the issue.
label
Sep 9, 2024
I am checking whether the testing run successfully on GitHub mock environment. Now the coverage looks like too low, I need to confirm if it has risk. |
microsoft-github-policy-service
bot
added
needs-team-attention
This issue needs attention from Azure service team or SDK team
and removed
needs-author-feedback
More information is needed from author to address the issue.
labels
Sep 9, 2024
JoyerJin
added
needs-review
and removed
needs-team-attention
This issue needs attention from Azure service team or SDK team
labels
Sep 10, 2024
Confirmed, no need to add test case. |
msJinLei
approved these changes
Sep 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
…track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk (#26036) * blueprint management sdk generated by autorest.csharp * blueprint management sdk generated by autorest.powershell * Update Assembly * Blueprint changelog * Update ChangeLog.md --------- Co-authored-by: Jin Lei <[email protected]>
github-actions bot
pushed a commit
to notyashhh/azure-powershell
that referenced
this pull request
Sep 13, 2024
…track 1 SDK and add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk (Azure#26036) * blueprint management sdk generated by autorest.csharp * blueprint management sdk generated by autorest.powershell * Update Assembly * Blueprint changelog * Update ChangeLog.md --------- Co-authored-by: Jin Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Microsoft.Azure.Management.Blueprint 0.20.7-preview dependencies
Add Microsoft.Azure.PowerShell.Blueprint.Management.Sdk
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.