Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDInsight] Fix a bug #26135

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[HDInsight] Fix a bug #26135

merged 3 commits into from
Sep 20, 2024

Conversation

yuc-Li
Copy link
Member

@yuc-Li yuc-Li commented Sep 19, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.HDInsight
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzHDInsightCluster 9 47 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightCluster 11 27 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.
⚠️ New-AzHDInsightCluster 13 42 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzHDInsightCluster 9 47 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
⚠️ New-AzHDInsightCluster 11 27 Unassigned_Variable New-AzHDInsightIPConfiguration -SubnetId $subnetId is a null-valued parameter value. -SubnetId Assign value for $subnetId.
⚠️ New-AzHDInsightCluster 13 42 Mismatched_Parameter_Value_Type New-AzHDInsightCluster -SecurityProfile $config.SecurityProfile is not an expected parameter value type. -SecurityProfile Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.HDInsight.Models.AzureHDInsightSecurityProfile. Now the type is .(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.38% Test coverage for the module cannot be lower than 50%.
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@yuc-Li yuc-Li marked this pull request as ready for review September 20, 2024 02:20
@msJinLei
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei msJinLei merged commit fff096b into Azure:main Sep 20, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
* Fix a bug

* Update changelog

* Update example

---------

Co-authored-by: v-yuchenli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants