Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivateEndpointVNetPolicies parameter (#26091) #26358

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

VeryEarly
Copy link
Contributor

  • Add PrivateEndpointVNetPolicies parameter

  • Update format.ps1xml

  • Some boilerplate code

  • Some more boilerplate code

  • Test

  • Fix

  • Parameter PrivateEndpointVNetPolicies of cmdlet New-AzVirtualNetwork does not follow the enforced naming convention of using a singular noun for a parameter name.

  • Update ChangeLog

  • Fix parameter name

  • Fix change log

  • Able to run test now

  • Creating a virtual network

  • Looks like default behavior is working

  • Fix comments

  • Setting PrivateEndpointVNetPolicies to Basic works

  • Enabling for PL64K is working

  • Disabling for PL64K is working

  • Testing is working

  • Update help file New-AzVirtualNetwork.md

  • Fix NrpTeamAlias


Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

* Add PrivateEndpointVNetPolicies parameter

* Update format.ps1xml

* Some boilerplate code

* Some more boilerplate code

* Test

* Fix

* Parameter PrivateEndpointVNetPolicies of cmdlet New-AzVirtualNetwork does not follow the enforced naming convention of using a singular noun for a parameter name.

* Update ChangeLog

* Fix parameter name

* Fix change log

* Able to run test now

* Creating a virtual network

* Looks like default behavior is working

* Fix comments

* Setting PrivateEndpointVNetPolicies to Basic works

* Enabling for PL64K is working

* Disabling for PL64K is working

* Testing is working

* Update help file New-AzVirtualNetwork.md

* Fix NrpTeamAlias

---------

Co-authored-by: Will Ehrich <[email protected]>
@VeryEarly VeryEarly self-assigned this Oct 17, 2024
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@VeryEarly VeryEarly merged commit cbbedfa into future Oct 17, 2024
12 checks passed
@VeryEarly VeryEarly deleted the temporary/sync-main-to-future-add75 branch October 17, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants