-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RunOn support and other issue fixes. #4349
Adding RunOn support and other issue fixes. #4349
Conversation
@vrdmr, |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr Hey Varad, a couple questions:
-
Do you plan to add test coverage for the cmdlets that are now using
RunOn
? -
Does this PR resolve issues New-AzureRmAutomationWebHook: add support for RunOn #3082 and Register-AzureRmAutomationScheduledRunbook: add support for RunOn #3197 ?
-
Can you update the change log with a snippet about the changes you are making in this PR?
@vrdmr There has been no activity on this PR in 10 days, we will have to close it this week if you do not address review feedback |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr it doesn't look like any of the tests that were modified are testing when a value is passed through for the runOn
parameter. Any reason for that?
@@ -39,6 +39,7 @@ public class NewAzureAutomationModule : AzureAutomationBaseCmdlet | |||
/// </summary> | |||
[Parameter(Position = 3, Mandatory = true, ValueFromPipelineByPropertyName = true, | |||
HelpMessage = "The url to a module zip package.")] | |||
[Alias("ContentLinkUri")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr I think it would be better if we changed the name of this parameter to ContentLinkUri
and added an alias to ContentLink
. That way, when users tab through the parameters, ContentLinkUri
will show up and will be consistent with what is shown when tabbing through the parameters of Set-AzureRmAutomationModule
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'll confirm with @safeermohammed and make the change asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cormacpayne Does changing he parameter name will be breaking change, i.e., does user already using the cmdlet need to do any thing? If this is not the case, fine to do as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr @safeermohammed if we swap the parameter name and its alias, it won't be a breaking change. Existing scripts will be able to continue to use ContentLink
; the only difference is when people tab through the possible parameters (as well as look at the docs for the cmdlet), they will see ContentLinkUri
, which I think is a better indication of what this parameter is. The use of ContentLink
is not lost in this swap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cormacpayne Thank you for confirmation, we will swap it
@cormacpayne - No particular reason for not passing any specific values for runOn. It is currently not a high priority scenario and we are in process of adding more functionality in the backend for it. |
[ValidateNotNullOrEmpty] | ||
public Uri ContentLink { get; set; } | ||
public Uri ContentLinkUri { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr you are still referencing ContentLink
below instead of ContentLinkUri
, which is causing compilation errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Adding runOn support for Scheduled Job and Webhook cmdlets; Also adding alias for Modules in New/Set Modules. The changes were required for couple of issues raised earlier.
Thanks @cormacpayne! :) |
Description
Adding runOn support for Scheduled Job and Webhook cmdlets; Also adding alias for Modules in New/Set Modules. The changes were required for couple of issues raised earlier.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines