added global reach flag in New-AzureExpressRouteCircuit cmdlet #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Aug 3, 2018
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true)] | ||
| [ValidateNotNullOrEmpty] | ||
| public bool AllowGlobalReach { get; set; } |
There was a problem hiding this comment.
Boolean parameters are discouraged. You should use a SwitchParameter instead.
| @@ -103,6 +103,11 @@ public class NewAzureExpressRouteCircuitCommand : ExpressRouteCircuitBaseCmdlet | |||
| [ValidateNotNullOrEmpty] | |||
| public bool? AllowClassicOperations { get; set; } | |||
|
|
|||
| [Parameter( | |||
There was a problem hiding this comment.
You should ensure the new parameter is covered in one of your tests
There was a problem hiding this comment.
I've updated an existing test to test this flag.
|
@syfarogh Code complete is today (8/6) Please make requested changes by EOD if you would like this PR in this release. |
|
The test is failing because it requires SDK generated from swagger network-august-release. |
markcowl
approved these changes
Aug 17, 2018
markcowl
requested changes
Aug 17, 2018
| @@ -154,7 +154,7 @@ function Test-ExpressRouteCircuitCRUD | |||
| $resourceGroup = New-AzureRmResourceGroup -Name $rgname -Location $rglocation | |||
|
|
|||
| # Create the ExpressRouteCircuit | |||
| $circuit = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500; | |||
| $circuit = New-AzureRmExpressRouteCircuit -Name $circuitName -Location $location -ResourceGroupName $rgname -SkuTier Standard -SkuFamily MeteredData -ServiceProviderName "equinix" -PeeringLocation "Silicon Valley" -BandwidthInMbps 500 -AllowGlobalReach; | |||
There was a problem hiding this comment.
Looks like you will need to re-record tests for this
|
@syfarogh Ping |
|
Closing per offline conversation that @syfarogh will open a new PR targeting a different branch. |
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added global reach flag in New-AzureExpressRouteCircuit cmdlet to toggle Global reach feature on a circuit.
Checklist
CONTRIBUTING.mdplatyPSmodule