resolve comments

Azure · Aug 9, 2024 · 3a616e0 · 3a616e0
1 parent 3e081e2
commit 3a616e0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/virtualWan.json b/specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/virtualWan.json
@@ -9988,6 +9988,7 @@
       "properties": {
         "sharedKey": {
           "type": "string",
+          "x-ms-secret": true,
           "description": "The value of the shared key for the vpn link connection."
         },
         "sharedKeyLength": {
@@ -10009,7 +10010,6 @@
       "type": "object",
       "properties": {
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/SharedKeyProperties",
           "description": "Properties of the shared key."
         },

diff --git a/specification/network/resource-manager/readme.md b/specification/network/resource-manager/readme.md
@@ -3599,6 +3599,18 @@ suppressions:
     reason: The resource name parameter 'bastionHostName' is not defined with a 'pattern' restriction. Suppress it for now to avoid breaking change because it is referenced by all Bastion APIs. 
   - code: LroErrorContent
     reason: CloudError does not follow required error schema. Suppress it for now to avoid breaking change because it is referenced by many files.
+  - code: ResourceNameRestriction
+    from: virtualWan.json
+    reason: The resource name parameter 'gatewayName', 'connectionName', 'linkConnectionName' is not defined with a 'pattern' restriction. Suppress it for now to avoid breaking change because it is referenced by all vpn link connection APIs.
+    where:
+    - $.paths.["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/vpnGateways/{gatewayName}/vpnConnections/{connectionName}/vpnLinkConnections/{linkConnectionName}/sharedKeys"]
+    - $.paths.["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/vpnGateways/{gatewayName}/vpnConnections/{connectionName}/vpnLinkConnections/{linkConnectionName}/sharedKeys/default"]
+    - $.paths.["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/vpnGateways/{gatewayName}/vpnConnections/{connectionName}/vpnLinkConnections/{linkConnectionName}/sharedKeys/default/listSharedKey"]
+    - code: BodyTopLevelProperties
+    from: virtualWan.json
+    reason: False alarm.
+    where:
+    - $.definitions.ConnectionSharedKeyResultList
 ```
 
 ## Go