Skip to content

Commit

Permalink
Added support for NGroups operations (#30379)
Browse files Browse the repository at this point in the history
* Copy files from preview/2024-05-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-09-01-preview

Updated the API version from preview/2024-05-01-preview to preview/2024-09-01-preview.

* Added tag for 2024-09-01-preview in readme file

* Added missing tags from the last release.

* resource name pattern fix

* match original?

* updated delete response

* try

* common?

* try to match

* location header added and 200 removed from delete

* more fixes

* fix json

* change camel case to be all lower in uri

* missing type object errors

* camel case fixes

* fix paramaeter name to match case

* Fixing XmsPageableForListCalls violation from containerInstance.json

* removed post 204 response

* removed 204 from post

* fix some type obejct references

* last camel case

* vnet name with pattern

* updated sku to get nextLink

* fixed json

* updated nextlink in paged response

* Fixing OperationsApiResponseSchema violation from containerInstance.json

* Fixing OperationsApiSchemaUsesCommonTypes violation from containerInstance.json

* fixed lint errors

* Fixing LroLocationHeader, LroErrorContent and MissingTypeObject violation from containerInstance.json

* camel case last

* attempt at some object type failures

* capital g in resource group

* wrap in tag

* revert to only Ngroups initial change

* readonly location in patch

* readonly fix

* revert path change and use common tracked resource schema

* fix location resource and readonly

* file not referenced

* remove unreferenced property

* npx make prettier

* remove standby from update

* added ngroups to cspell

* npx prettier for all examples

* Addressing PR feedback.

* Baseline file from stable-2023-05-01 for reference.

* Revert: Baseline file from stable-2023-05-01 for reference.

* Fixing spell check and Lint error.

* spellcheck fix

* TrackedResource has a required field for location, which is not needed for PATCH operation. So reverted it.

* spellcheck fix2

* nit

* Location property in PAtch operation should be readOnly or immutable.

* addressed comments

* updated provisioningState

* added headers in the PUT response

* used common managedIdentity for nGroups

* Revert "used common managedIdentity for nGroups"

This reverts commit fb6a58f.

* added long-running-operation-options

* updated long-running-operation-options

* updated headers in response

* fixed lint errors

---------

Co-authored-by: John Richardson <[email protected]>
Co-authored-by: Shivam Gupta <[email protected]>
  • Loading branch information
3 people authored Oct 2, 2024
1 parent 3b273b8 commit 482e8ac
Show file tree
Hide file tree
Showing 26 changed files with 5,093 additions and 0 deletions.
6 changes: 6 additions & 0 deletions cSpell.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,12 @@
"Noreuse"
]
},
{
"filename": "**/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/preview/**/containerInstance.json",
"words": [
"ngroups"
]
},
{
"filename": "**/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/**/*json",
"words": [
Expand Down
Loading

0 comments on commit 482e8ac

Please sign in to comment.