Move DNS to use the common definition for resource groups (#3219)

Azure · Jun 12, 2018 · 9e68aa9 · 9e68aa9
1 parent 1432f67
commit 9e68aa9
Show file tree

Hide file tree

Showing 6 changed files with 54 additions and 266 deletions.
diff --git a/specification/common-types/resource-management/v1/types.json b/specification/common-types/resource-management/v1/types.json
@@ -296,7 +296,7 @@
    "pattern": "^[-\\w\\._\\(\\)]+$",
    "minLength": 1,
    "maxLength": 90,
-   "x-ms-parameter-location": "client"
+   "x-ms-parameter-location": "method"
   }
  }
 }
diff --git a/specification/dns/resource-manager/Microsoft.Network/preview/2015-05-04-preview/dns.json b/specification/dns/resource-manager/Microsoft.Network/preview/2015-05-04-preview/dns.json
@@ -45,11 +45,7 @@
         "description": "Creates a RecordSet within a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -135,11 +131,7 @@
         "description": "Removes a RecordSet from a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -204,11 +196,7 @@
         "description": "Gets a RecordSet.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -272,11 +260,7 @@
         "description": "Lists the RecordSets of a specified type in a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group that contains the zone."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -350,11 +334,7 @@
         "description": "Lists all RecordSets in a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group that contains the zone."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -407,11 +387,7 @@
         "description": "Creates a DNS zone within a resource group.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -468,11 +444,7 @@
         "description": "Removes a DNS zone from a resource group.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -508,11 +480,7 @@
         "description": "Gets a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -547,11 +515,7 @@
         "description": "Lists the DNS zones within a resource group.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "$top",

diff --git a/specification/dns/resource-manager/Microsoft.Network/preview/2018-03-01-preview/dns.json b/specification/dns/resource-manager/Microsoft.Network/preview/2018-03-01-preview/dns.json
@@ -36,11 +36,7 @@
         "description": "Updates a record set within a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -159,11 +155,7 @@
         "description": "Creates or updates a record set within a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -296,11 +288,7 @@
         "description": "Deletes a record set from a DNS zone. This operation cannot be undone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -407,11 +395,7 @@
         "description": "Gets a record set.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -515,11 +499,7 @@
         "description": "Lists the record sets of a specified type in a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -633,11 +613,7 @@
         "description": "Lists all record sets in a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -701,11 +677,7 @@
         "description": "Lists all record sets in a DNS zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -770,11 +742,7 @@
         "description": "Creates or updates a DNS zone. Does not modify DNS records within the zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -849,11 +817,7 @@
         "description": "Deletes a DNS zone. WARNING: All DNS records in the zone will also be deleted. This operation cannot be undone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -909,11 +873,7 @@
         "description": "Gets a DNS zone. Retrieves the zone properties, but not the record sets within the zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -957,11 +917,7 @@
         "description": "Updates a DNS zone. Does not modify DNS records within the zone.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "zoneName",
@@ -1024,11 +980,7 @@
         "description": "Lists the DNS zones within a resource group.",
         "parameters": [
           {
-            "name": "resourceGroupName",
-            "in": "path",
-            "required": true,
-            "type": "string",
-            "description": "The name of the resource group."
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
           },
           {
             "name": "$top",