Reduced warnings count (#6043)

* Suppress "expected" warnings * Refactored ApiVersion, SubscriptionId params usage * Fixed VMSS related warnings
Azure · May 22, 2019 · b03ac09 · b03ac09
1 parent ed71a2b
commit b03ac09
Show file tree

Hide file tree

Showing 7 changed files with 76 additions and 156 deletions.
diff --git a/...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/azureFirewallFqdnTag.json b/...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/azureFirewallFqdnTag.json
@@ -43,10 +43,10 @@
             "description":"Gets all the Azure Firewall FQDN Tags in a subscription.",
             "parameters":[
                {
-                  "$ref":"#/parameters/ApiVersionParameter"
+                  "$ref": "./network.json#/parameters/ApiVersionParameter"
                },
                {
-                  "$ref":"#/parameters/SubscriptionIdParameter"
+                  "$ref": "./network.json#/parameters/SubscriptionIdParameter"
                }
             ],
             "responses":{
@@ -120,21 +120,5 @@
          },
          "description":"Response for ListAzureFirewallFqdnTags API service call."
       }
-   },
-   "parameters": {
-      "SubscriptionIdParameter": {
-         "name": "subscriptionId",
-         "in": "path",
-         "required": true,
-         "type": "string",
-         "description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
-      },
-      "ApiVersionParameter": {
-         "name": "api-version",
-         "in": "query",
-         "required": true,
-         "type": "string",
-         "description": "Client API version."
-      }
    }
 }
diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/network.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/network.json
@@ -282,6 +282,20 @@
       "required": true,
       "type": "string",
       "description": "Client API version."
+    },
+    "ApiVersionVmssParameter": {
+      "name": "api-version",
+      "in": "query",
+      "required": true,
+      "type": "string",
+      "enum": [
+        "2017-03-30"
+      ],
+      "x-ms-enum": {
+        "name": "ApiVersion",
+        "modelAsString": true
+      },
+      "description": "Client API version."
     }
   }
 }
diff --git a/...ation/network/resource-manager/Microsoft.Network/stable/2019-04-01/virtualNetworkTap.json b/...ation/network/resource-manager/Microsoft.Network/stable/2019-04-01/virtualNetworkTap.json
@@ -301,8 +301,8 @@
             }
         }
     }
-},
-"definitions": {
+  },
+  "definitions": {
     "VirtualNetworkTap": {
         "properties": {
             "properties": {
@@ -374,21 +374,5 @@
         },
         "description": "Response for ListVirtualNetworkTap API service call."
     }
-},
-"parameters": {
-    "SubscriptionIdParameter": {
-        "name": "subscriptionId",
-        "in": "path",
-        "required": true,
-        "type": "string",
-        "description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
-    },
-    "ApiVersionParameter": {
-        "name": "api-version",
-        "in": "query",
-        "required": true,
-        "type": "string",
-        "description": "Client API version."
-    }
- }
+  }
 }
diff --git a/...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssNetworkInterface.json b/...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssNetworkInterface.json
@@ -64,18 +64,7 @@
             "description": "The virtual machine index."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -120,18 +109,7 @@
             "description": "The name of the virtual machine scale set."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -190,18 +168,7 @@
             "description": "The name of the network interface."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -264,18 +231,7 @@
             "description": "The name of the network interface."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -348,18 +304,7 @@
             "description": "The name of the ip configuration."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"

diff --git a/...ion/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssPublicIpAddress.json b/...ion/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssPublicIpAddress.json
@@ -54,18 +54,7 @@
             "description": "The name of the virtual machine scale set."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -128,18 +117,7 @@
             "description": "The IP configuration name."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"
@@ -209,18 +187,7 @@
             "description": "The name of the public IP Address."
           },
           {
-            "name": "api-version",
-            "in": "query",
-            "required": true,
-            "type": "string",
-            "enum": [
-              "2017-03-30"
-            ],
-            "x-ms-enum": {
-              "name": "ApiVersion",
-              "modelAsString": true
-            },
-            "description": "Client API version."
+            "$ref": "./network.json#/parameters/ApiVersionVmssParameter"
           },
           {
             "$ref": "./network.json#/parameters/SubscriptionIdParameter"

diff --git a/.../network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json b/.../network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json
@@ -55,10 +55,10 @@
             "description": "The name of the resource group."
           },
           {
-            "$ref": "#/parameters/SubscriptionIdParameter"
+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
           },
           {
-            "$ref": "#/parameters/ApiVersionParameter"
+            "$ref": "./network.json#/parameters/ApiVersionParameter"
           }
         ],
         "responses": {
@@ -136,10 +136,10 @@
             "description": "The name of the policy."
           },
           {
-            "$ref": "#/parameters/SubscriptionIdParameter"
+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
           },
           {
-            "$ref": "#/parameters/ApiVersionParameter"
+            "$ref": "./network.json#/parameters/ApiVersionParameter"
           }
         ],
         "responses": {
@@ -179,7 +179,7 @@
             "description": "The name of the policy."
           },
           {
-            "$ref": "#/parameters/SubscriptionIdParameter"
+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
           },
           {
             "description": "Policy to be created.",
@@ -237,10 +237,10 @@
             "description": "The name of the policy."
           },
           {
-            "$ref": "#/parameters/SubscriptionIdParameter"
+            "$ref": "./network.json#/parameters/SubscriptionIdParameter"
           },
           {
-            "$ref": "#/parameters/ApiVersionParameter"
+            "$ref": "./network.json#/parameters/ApiVersionParameter"
           }
         ],
         "responses": {
@@ -533,21 +533,5 @@
         }
       }
     }
-  },
-  "parameters": {
-    "SubscriptionIdParameter": {
-      "name": "subscriptionId",
-      "in": "path",
-      "required": true,
-      "type": "string",
-      "description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
-    },
-    "ApiVersionParameter": {
-      "name": "api-version",
-      "in": "query",
-      "required": true,
-      "type": "string",
-      "description": "Client API version."
-    }
   }
 }
diff --git a/specification/network/resource-manager/readme.md b/specification/network/resource-manager/readme.md
@@ -1017,6 +1017,48 @@ directive:
   - suppress: RequiredPropertiesMissingInResourceModel
     from: webapplicationfirewall.json
     reason: name, id and type properties are inherited from the upper level
+  - suppress: PostOperationIdContainsUrlVerb
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/getBackendHealthOnDemand"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: PostOperationIdContainsUrlVerb
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/vpnConfiguration"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/backendhealth"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkInterfaces/{networkInterfaceName}/effectiveRouteTable"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/securityGroupView"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/connectionMonitors/{connectionMonitorName}/query"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/networkConfigurationDiagnostic"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/CheckIPAddressAvailability"].get.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getBgpPeerStatus"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getVpnClientConnectionHealth"].post.operationId
+    reason: Customized verb is used for API
+  - suppress: ListInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
+    reason: Customized verb is used for API
+  - suppress: GetInOperationName
+    where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
+    reason: Customized verb is used for API
 ```
 
 ---