Fix `identity` in servicebus swagger #10380

ArcturusZhang · 2020-08-07T06:30:06Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-07T06:30:10Z

[Staging] Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L1292:9 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L1292:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L1297:9 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L1296:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'identity' renamed or removed? New: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L973:7 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L969:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'identity' renamed or removed? New: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L973:7 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L969:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'identity' renamed or removed? New: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L973:7 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/servicebus-preview.json#L969:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-07T06:30:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-08-07T06:31:21Z

Can one of the admins verify this patch?

ArcturusZhang · 2020-08-07T06:35:14Z

Please do not merge this PR until the service team approves this.

And breaking change is expected since this is a bug fix. Please find context in this issue

openapi-sdkautomation · 2020-08-07T06:41:19Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5f6fca8 with merge commit 925695f. SDK Automation 13.0.17.20200807.2
️✔️preview/servicebus/mgmt/2018-01-01-preview [View full logs] [Release SDK Changes]
- preview.servicebus.mgmt.2018-01-01-preview.zip
⚠️servicebus/mgmt/2015-08-01 [View full logs]
- servicebus.mgmt.2015-08-01.zip
```
No file is changed.
```
⚠️servicebus/mgmt/2017-04-01 [View full logs]
- servicebus.mgmt.2017-04-01.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-08-07T06:42:39Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5f6fca8 with merge commit 925695f. SDK Automation 13.0.17.20200807.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ServiceBus [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ServiceBus.2.1.0.nupkg
- Microsoft.Azure.Management.ServiceBus.2.1.0.snupkg

openapi-sdkautomation · 2020-08-07T06:43:11Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-07T06:43:27Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5f6fca8 with merge commit 925695f. SDK Automation 13.0.17.20200807.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-07T06:43:27Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5f6fca8 with merge commit 925695f. SDK Automation 13.0.17.20200807.2
️✔️sdk/servicebus/mgmt-v2015_08_01 [View full logs] [Release SDK Changes]

⚠️sdk/servicebus/mgmt-v2017_04_01 [View full logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicebus: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionImpl.java:[16,92] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerModelT
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicebus/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/servicebus/v2017_04_01/implementation/PremiumMessagingRegionsImpl.java:[21,122] type argument com.microsoft.azure.management.servicebus.v2017_04_01.implementation.PremiumMessagingRegionInner is not within bounds of type-variable InnerT
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

️✔️sdk/servicebus/mgmt-v2018_01_01_preview [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-08-07T06:44:38Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5f6fca8 with merge commit 925695f. SDK Automation 13.0.17.20200807.2

️✔️azure-mgmt-servicebus [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-servicebus
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-servicebus
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 1.468% size of original (original: 51703 chars, delta: 759 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation NamespacesOperations.list_network_rule_sets

openapi-sdkautomation · 2020-08-07T06:44:42Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-07T06:45:21Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

v-Ajnava

Approved, its bug fix.

erich-wang · 2020-08-10T02:01:00Z

@ArcturusZhang, is this PR ready to merge?

ArcturusZhang · 2020-08-10T02:27:17Z

@ArcturusZhang, is this PR ready to merge?

Yes, the service team has approved this change, Please go ahead and merge this fix.

* Fix identity in servicebus * Principal ID and tenant ID should be readonly

ArcturusZhang added 2 commits August 7, 2020 14:27

Fix identity in servicebus

8257530

Principal ID and tenant ID should be readonly

5f6fca8

ArcturusZhang requested a review from v-Ajnava as a code owner August 7, 2020 06:30

openapi-assignment-bot bot assigned erich-wang Aug 7, 2020

ArcturusZhang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2020

v-Ajnava approved these changes Aug 7, 2020

View reviewed changes

v-Ajnava removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2020

erich-wang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 11, 2020

erich-wang merged commit 925695f into Azure:master Aug 11, 2020

innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020

Fix identity in servicebus swagger (Azure#10380)

13654a3

* Fix identity in servicebus * Principal ID and tenant ID should be readonly

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `identity` in servicebus swagger #10380

Fix `identity` in servicebus swagger #10380

ArcturusZhang commented Aug 7, 2020

openapi-pipeline-app bot commented Aug 7, 2020 •

edited

Loading

azure-pipelines bot commented Aug 7, 2020

azuresdkci commented Aug 7, 2020

ArcturusZhang commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

v-Ajnava left a comment

erich-wang commented Aug 10, 2020

ArcturusZhang commented Aug 10, 2020

Fix identity in servicebus swagger #10380

Fix identity in servicebus swagger #10380

Conversation

ArcturusZhang commented Aug 7, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 7, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 7, 2020

azuresdkci commented Aug 7, 2020

ArcturusZhang commented Aug 7, 2020 • edited Loading

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

Trenton Generation - Release

v-Ajnava left a comment

Choose a reason for hiding this comment

erich-wang commented Aug 10, 2020

ArcturusZhang commented Aug 10, 2020

Fix `identity` in servicebus swagger #10380

Fix `identity` in servicebus swagger #10380

openapi-pipeline-app bot commented Aug 7, 2020 •

edited

Loading

ArcturusZhang commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading