create new TA preview API v3.1-preview.2 #10440

laramume · 2020-08-12T18:50:30Z

Changes in the PR

New Preview API v3.1-preview.2 which introduces bingId property in /entities/linking and redactedText in /entities/recognition/pii
Add a new query param called "stringIndexType" to return offsets based on the value in v3.1-preview.1 API
Fix Swagger Error Response bug in all V3 API's

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

…ersion to avoid breaking changes in client side code

Add StringIndex param information and PII Redaction updates to Swagger

openapi-pipeline-app · 2020-08-12T18:50:37Z

[Staging] Swagger Validation Report

️❌BreakingChange: 140 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'InvalidRequest, InvalidArgument, InternalServerError, ServiceUnavailable' from the old version. New: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L413:9 Old: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L462:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'InvalidParameterValue, InvalidRequestBodyFormat, EmptyRequest, MissingInputRecords, InvalidDocument, ModelVersionIncorrect, InvalidDocumentBatch, UnsupportedLanguageCode, InvalidCountryHint' from the old version. New: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L484:9 Old: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L533:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'InvalidRequest, InvalidArgument, InternalServerError, ServiceUnavailable' from the old version. New: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L413:9 Old: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L462:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'InvalidParameterValue, InvalidRequestBodyFormat, EmptyRequest, MissingInputRecords, InvalidDocument, ModelVersionIncorrect, InvalidDocumentBatch, UnsupportedLanguageCode, InvalidCountryHint' from the old version. New: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L484:9 Old: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L533:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L398:7 Old: TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json#L461:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L448:7 Old: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L449:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L448:7 Old: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L449:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'target' renamed or removed? New: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L448:7 Old: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L449:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'innerError' renamed or removed? New: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L448:7 Old: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L449:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'details' renamed or removed? New: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L448:7 Old: TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json#L449:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-12T18:50:47Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-12T18:53:00Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 877b90a with merge commit 66d6390. SDK Automation 13.0.17.20200807.2

️✔️@azure/cognitiveservices-textanalytics [View full logs] [Release SDK Changes]

azure-cognitiveservices-textanalytics-4.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/textAnalyticsClient.js → ./dist/cognitiveservices-textanalytics.js...
[npmPack] created ./dist/cognitiveservices-textanalytics.js in 172ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 32.5kB dist/cognitiveservices-textanalytics.js        
[npmPack] npm notice 10.6kB dist/cognitiveservices-textanalytics.min.js    
[npmPack] npm notice 345B   esm/models/index.js                            
[npmPack] npm notice 18.5kB esm/models/mappers.js                          
[npmPack] npm notice 803B   esm/models/parameters.js                       
[npmPack] npm notice 1.0kB  rollup.config.js                               
[npmPack] npm notice 4.6kB  esm/textAnalyticsClient.js                     
[npmPack] npm notice 2.0kB  esm/textAnalyticsClientContext.js              
[npmPack] npm notice 1.7kB  package.json                                   
[npmPack] npm notice 457B   tsconfig.json                                  
[npmPack] npm notice 67.1kB dist/cognitiveservices-textanalytics.js.map    
[npmPack] npm notice 9.5kB  dist/cognitiveservices-textanalytics.min.js.map
[npmPack] npm notice 5.1kB  esm/models/index.d.ts.map                      
[npmPack] npm notice 126B   esm/models/index.js.map                        
[npmPack] npm notice 1.1kB  esm/models/mappers.d.ts.map                    
[npmPack] npm notice 10.3kB esm/models/mappers.js.map                      
[npmPack] npm notice 255B   esm/models/parameters.d.ts.map                 
[npmPack] npm notice 508B   esm/models/parameters.js.map                   
[npmPack] npm notice 1.8kB  esm/textAnalyticsClient.d.ts.map               
[npmPack] npm notice 2.8kB  esm/textAnalyticsClient.js.map                 
[npmPack] npm notice 398B   esm/textAnalyticsClientContext.d.ts.map        
[npmPack] npm notice 970B   esm/textAnalyticsClientContext.js.map          
[npmPack] npm notice 3.6kB  README.md                                      
[npmPack] npm notice 13.6kB esm/models/index.d.ts                          
[npmPack] npm notice 13.3kB src/models/index.ts                            
[npmPack] npm notice 1.4kB  esm/models/mappers.d.ts                        
[npmPack] npm notice 14.5kB src/models/mappers.ts                          
[npmPack] npm notice 210B   esm/models/parameters.d.ts                     
[npmPack] npm notice 810B   src/models/parameters.ts                       
[npmPack] npm notice 4.9kB  esm/textAnalyticsClient.d.ts                   
[npmPack] npm notice 8.8kB  src/textAnalyticsClient.ts                     
[npmPack] npm notice 758B   esm/textAnalyticsClientContext.d.ts            
[npmPack] npm notice 1.7kB  src/textAnalyticsClientContext.ts              
[npmPack] npm notice 1.1kB  LICENSE.txt                                    
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/cognitiveservices-textanalytics         
[npmPack] npm notice version:       4.0.0                                          
[npmPack] npm notice filename:      azure-cognitiveservices-textanalytics-4.0.0.tgz
[npmPack] npm notice package size:  32.0 kB                                        
[npmPack] npm notice unpacked size: 237.3 kB                                       
[npmPack] npm notice shasum:        5b1df9aacbc66dfc7e8af2fade6bbfa2530aa6bc       
[npmPack] npm notice integrity:     sha512-kQCZKgUxT/14U[...]21zcUjNa+R1MQ==       
[npmPack] npm notice total files:   34                                             
[npmPack] npm notice

openapi-sdkautomation · 2020-08-12T18:53:01Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-12T18:53:03Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 877b90a with merge commit 66d6390. SDK Automation 13.0.17.20200807.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/TextAnalyticsClient.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/implementation/TextAnalyticsClientImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/implementation/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/DetectedLanguage.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/DocumentStatistics.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntitiesBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntitiesBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/EntityRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorResponse.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/ErrorResponseException.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/InternalError.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/KeyPhraseBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/KeyPhraseBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/LanguageInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MatchRecord.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MultiLanguageBatchInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/MultiLanguageInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/RequestStatistics.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/SentimentBatchResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/SentimentBatchResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/models/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/language/textanalytics/src/main/java/com/microsoft/azure/cognitiveservices/language/textanalytics/package-info.java

openapi-sdkautomation · 2020-08-12T18:53:03Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 877b90a with merge commit 66d6390. SDK Automation 13.0.17.20200807.2
⚠️cognitiveservices/v2.0 [View full logs]
- cognitiveservices.v2.0.zip
```
No file is changed.
```
⚠️cognitiveservices/v2.1 [View full logs]
- cognitiveservices.v2.1.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-08-12T18:53:06Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 877b90a with merge commit 66d6390. SDK Automation 13.0.17.20200807.2

️✔️azure-cognitiveservices-language-textanalytics [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-language-textanalytics
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-language-textanalytics
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Traceback (most recent call last):
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
[ChangeLog]     "__main__", mod_spec)
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
[ChangeLog]     exec(code, run_globals)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
[ChangeLog]     change_log = build_change_log(old_report, new_report)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
[ChangeLog]     change_log.operation(diff_line)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
[ChangeLog]     _, operation_name, *remaining_path = path
[ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
[ChangeLog] Size of delta 7.210% size of original (original: 8641 chars, delta: 623 chars)

openapi-sdkautomation · 2020-08-12T18:53:11Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-12T18:53:25Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-12T18:53:27Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-12T18:56:01Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-08-12T19:10:34Z

Can one of the admins verify this patch?

assafi · 2020-08-12T23:12:02Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json

+            "enum" : [ "textelement_v8", "unicodecodepoint", "utf16codeunit" ],
+            "default" : "textelement_v8",
+            "required": false
+          },


Please see my v3.2-preview.1 PR. It includes v3.1-preview.1 updates that should be incorporated here as well.

I have synced this with that PR and this also follows the same conventions now

azure-pipelines · 2020-08-12T23:51:27Z

Azure Pipelines successfully started running 1 pipeline(s).

laramume · 2020-08-13T00:10:37Z

@tjprescott @yangyuan Could you guys take a look at this?

azure-pipelines · 2020-08-13T20:40:30Z

Azure Pipelines successfully started running 1 pipeline(s).

tjprescott · 2020-08-17T19:40:12Z

You will need to reach out to @lmazuel to be able to merge this with breaking changes.

iscai-msft · 2020-08-19T17:15:32Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json

+            "$ref": "#/parameters/MultiLanguageInput"
+          },
+          {
+            "$ref": "#/parameters/StringIndexType"


is string index type also being added to v3.1-preview.1? My understanding was that it was being added v3.1-preview.2 and onward

Yes its being added to v3.1-preview.1 also. I was not in the discussions for it. @thediris might know better

johanste · 2020-08-19T18:12:57Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json

@@ -77,10 +77,16 @@
              "$ref": "#/definitions/EntitiesResult"
            }
          },
-          "default": {


You probably want to keep the default (e.g. what are you returning on a 429 response?)

Sure I will add those

johanste

Please consider keeping the "default" error declaration rather than the individual error codes. If you do want individual error codes, they should be marked with x-ms-error-response to clearly indicate to autorest and friends that it is an error case/expected to raise an exception.

iscai-msft · 2020-08-19T18:21:47Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json

+              }
+           ]
+        },
+        "x-ms-parameter-location":"client"


Why are you choosing to make it a client parameter instead of a method parameter?

For python multiapi, it'll be better to have this on the method level. We haven't dealt with client parameters that are required for some versions, and don't exist for others

@assafi had this defined in another PR which I just copied over. Assaf is there a reason to have it like this? @thediris if you have an answer for this please let us know

@johanste do you have any input regarding string index type being a client parameter?

I believe this was based on the assumption that we wouldn't provide a parameter at all for the encoding. But based on the conversation in the arch board review (scenario where I may want to change it when storing something in a database to be consumed by a different language etc.), it is probably better to (still not exposing it as a parameter in the first release) have it as a per-method parameter.

I have changed it to method. @assafi Please let us know if you have any concerns

Yep. Agreed with everything that's been said. Thanks for the feedback everyone.

azure-pipelines · 2020-08-21T00:21:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-21T02:20:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-21T02:28:11Z

Azure Pipelines successfully started running 1 pipeline(s).

tjprescott · 2020-08-21T20:54:15Z

I don't have permissions to merge this because the Breaking Change check is failing. If BCs are approved, you will need to ask @lmazuel to merge this.

iscai-msft · 2020-08-24T17:52:47Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json

+          }
+        ]
+      },
+      "x-ms-parameter-location": "client"


looks like the parameter location for this string index type is still client

azure-pipelines · 2020-08-24T19:12:24Z

Azure Pipelines successfully started running 1 pipeline(s).

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json

azure-pipelines · 2020-08-24T21:43:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-25T15:52:10Z

Azure Pipelines successfully started running 1 pipeline(s).

deyaaeldeen · 2020-08-28T21:07:10Z

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.1/TextAnalytics.json

+          "x-ms-enum": {
+            "name": "TokenSentimentValue",
+            "modelAsString": false
+          },


why was this added? cc @iscai-msft

This changes the name of the generated enum class, and ensures that the enum is non-extensible, I'm assuming those were the reasons it was added, @laramume for confirmation

So it is an implementation of the new guidelines defined here: microsoft/api-guidelines#213. Thanks @iscai-msft.

I'm actually not sure myself what this is. @laramume - please remove this if not needed.

laramume and others added 10 commits October 26, 2018 09:41

updated model names in preview version to be consistent with stable v…

5787a88

…ersion to avoid breaking changes in client side code

changed swagger files

4149f66

Merge remote-tracking branch 'upstream/master'

9836271

Merge remote-tracking branch 'upstream/master'

f7062ca

Merge remote-tracking branch 'upstream/master'

e38d49c

new preview API v3.1-preview.2

ebe6e08

new preview API v3.1-preview.2

8983fbb

new preview API v3.1-preview.2

34cf2bd

Add the changes to the swagger

d0d866f

Merge pull request #12 from thediris/users/laramume/V31Preview2API

02111dc

Add StringIndex param information and PII Redaction updates to Swagger

laramume requested a review from yangyuan as a code owner August 12, 2020 18:50

openapi-assignment-bot bot assigned tjprescott Aug 12, 2020

openapi-sdkautomation bot mentioned this pull request Aug 12, 2020

[AutoPR azure-cognitiveservices-language-textanalytics] create new TA preview API v3.1-preview.2 AzureSDKAutomation/azure-sdk-for-python#1778

Closed

new preview API

60d2534

assafi reviewed Aug 12, 2020

View reviewed changes

sync with v3.2-preview.1 API conventions

a55e796

fix build issues

0c50e96

This was referenced Aug 17, 2020

[TA] Adding support for PII endpoint Azure/azure-sdk-for-java#13687

Merged

[text analytics] add bing ID property for LinkedEntity Azure/azure-sdk-for-net#14091

Closed

iscai-msft reviewed Aug 19, 2020

View reviewed changes

johanste reviewed Aug 19, 2020

View reviewed changes

johanste approved these changes Aug 19, 2020

View reviewed changes

iscai-msft reviewed Aug 19, 2020

View reviewed changes

resolve PR comments

449997b

fix prettier check

de5f432

fix prettier check in v2.1

89ff1fe

tjprescott approved these changes Aug 21, 2020

View reviewed changes

iscai-msft reviewed Aug 24, 2020

View reviewed changes

resolve PR comments

76fd1cb

assafi reviewed Aug 24, 2020

View reviewed changes

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.0-preview.1/TextAnalytics.json Outdated Show resolved Hide resolved

assafi reviewed Aug 24, 2020

View reviewed changes

...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.2/TextAnalytics.json Outdated Show resolved Hide resolved

resolve PR comments

a64c2bd

iscai-msft approved these changes Aug 25, 2020

View reviewed changes

resolve PR comments

877b90a

johanste approved these changes Aug 25, 2020

View reviewed changes

mayurid merged commit 66d6390 into Azure:master Aug 25, 2020

deyaaeldeen reviewed Aug 28, 2020

View reviewed changes

create new TA preview API v3.1-preview.2 #10440

create new TA preview API v3.1-preview.2 #10440

Conversation

laramume commented Aug 12, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 12, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 12, 2020

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 12, 2020 • edited Loading

Trenton Generation - Release

azure-pipelines bot commented Aug 12, 2020

azuresdkci commented Aug 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 12, 2020

laramume commented Aug 13, 2020

azure-pipelines bot commented Aug 13, 2020

tjprescott commented Aug 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johanste left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 21, 2020

azure-pipelines bot commented Aug 21, 2020

azure-pipelines bot commented Aug 21, 2020

tjprescott commented Aug 21, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 24, 2020

azure-pipelines bot commented Aug 24, 2020

azure-pipelines bot commented Aug 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2020 •

edited

Loading