Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the readme.md for go SDK in hybridcompute #10471

Merged

Conversation

ArcturusZhang
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 14, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020

azure-resource-manager-schemas - Release

failed [Logs] [Expand Details]
  • Generate from ef607b3 with merge commit a8c52f7. Schema Automation 13.0.17.20200807.2
  • hybridcompute [View full logs
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5613 passing (1m)
      AzureResourceSchema has no registered package commands.
      SDK Repository Package Error: HttpError: Resource not accessible by integration, {"name":"HttpError","status":403,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 14 Aug 2020 07:26:53 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"403 Forbidden","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0880:533D:2723A2E:408CDA8:5F363CBD","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14617","x-ratelimit-reset":"1597391738","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/repos/Azure/azure-resource-manager-schemas/pulls","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{\"base\":\"master\",\"head\":\"AzureSDKAutomation:sdkAutomation/hybridcompute\",\"title\":\"[ReleasePR hybridcompute] Refactor the readme.md for go SDK in hybridcompute\",\"body\":\"Created to release hybridcompute.Reopen this PR to release the SDK.\\nIf you can't reopen it, click here to create a new one.\",\"maintainer_can_modify\":false}","request":{"validate":{"base":{"required":true,"type":"string"},"body":{"type":"string"},"draft":{"type":"boolean"},"head":{"required":true,"type":"string"},"maintainer_can_modify":{"type":"boolean"},"owner":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"title":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 14, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ef607b3 with merge commit a8c52f7. SDK Automation 13.0.17.20200807.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 14, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ef607b3 with merge commit a8c52f7. SDK Automation 13.0.17.20200807.2
    • ⚠️azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridcompute
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridcompute
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 64.392% size of original (original: 22894 chars, delta: 14742 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model Machine has a new parameter identity
      [ChangeLog]   - Model Machine has a new parameter location_data
      [ChangeLog]   - Model MachineUpdate has a new parameter location_data
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Model Machine no longer has parameter principal_id
      [ChangeLog]   - Model Machine no longer has parameter tenant_id
      [ChangeLog]   - Model Machine no longer has parameter physical_location
      [ChangeLog]   - Model Machine no longer has parameter type1
      [ChangeLog]   - Model MachineUpdate no longer has parameter physical_location
      [ChangeLog]   - Model Resource no longer has parameter tags
      [ChangeLog]   - Model Resource no longer has parameter tenant_id
      [ChangeLog]   - Model Resource no longer has parameter principal_id
      [ChangeLog]   - Model Resource no longer has parameter location
      [ChangeLog]   - Model Resource no longer has parameter type1
      [ChangeLog]   - Model MachineExtension no longer has parameter type1
      [ChangeLog]   - Model MachineExtension no longer has parameter tenant_id
      [ChangeLog]   - Model MachineExtension no longer has parameter principal_id
      [ChangeLog]   - Model ErrorResponse has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 14, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 14, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ef607b3 with merge commit a8c52f7. SDK Automation 13.0.17.20200807.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.HybridCompute [View full logs]  [Release SDK Changes]
        No Artifact Generated.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 14, 2020

      azure-sdk-for-go - Release

      ⚠️ warning [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 14, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 14, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 14, 2020

      azure-sdk-for-java - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @ArcturusZhang ArcturusZhang merged commit a8c52f7 into Azure:master Aug 14, 2020
      @ArcturusZhang ArcturusZhang deleted the refactor-go-sdk-readme-hybridcompute branch August 14, 2020 07:22
      innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants