[AppConfiguration] Added missing "publicNetworkAccess" property for patch request #10479

avanigupta · 2020-08-14T21:13:21Z

In the initial release of this spec, we added a property called publicNetworkAccess in ConfigurationStoreProperties object but missed adding it to ConfigurationStorePropertiesUpdateParameters object.
Since we already have this property for PUT requests, this PR is to add the same property for PATCH requests.
This is not a breaking change.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

…eParameters

openapi-pipeline-app · 2020-08-14T21:13:25Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-14T21:13:40Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-14T21:16:51Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2
️✔️sdk/appconfiguration/mgmt-v2019_02_01_preview [View full logs] [Release SDK Changes]
️✔️sdk/appconfiguration/mgmt-v2019_10_01 [View full logs] [Release SDK Changes]
️✔️sdk/appconfiguration/mgmt-v2020_06_01 [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-08-14T21:17:00Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2
⚠️appconfiguration/mgmt/2019-10-01 [View full logs]
- appconfiguration.mgmt.2019-10-01.zip
```
No file is changed.
```
⚠️preview/appconfiguration/mgmt/2019-02-01-preview [View full logs]
- preview.appconfiguration.mgmt.2019-02-01-preview.zip
```
No file is changed.
```
⚠️preview/appconfiguration/mgmt/2019-11-01-preview [View full logs]
- preview.appconfiguration.mgmt.2019-11-01-preview.zip
```
No file is changed.
```
️✔️preview/appconfiguration/mgmt/2020-06-01 [View full logs] [Release SDK Changes]
- preview.appconfiguration.mgmt.2020-06-01.zip

openapi-sdkautomation · 2020-08-14T21:17:27Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-08-14T21:17:37Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-08-14T21:18:18Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2

️✔️@azure/arm-appconfiguration [View full logs] [Release SDK Changes]

azure-arm-appconfiguration-1.2.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/appConfigurationManagementClient.js → ./dist/arm-appconfiguration.js...
[npmPack] created ./dist/arm-appconfiguration.js in 317ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 1.9kB   esm/appConfigurationManagementClient.js              
[npmPack] npm notice 2.6kB   esm/appConfigurationManagementClientContext.js       
[npmPack] npm notice 79.9kB  dist/arm-appconfiguration.js                         
[npmPack] npm notice 26.7kB  dist/arm-appconfiguration.min.js                     
[npmPack] npm notice 16.7kB  esm/operations/configurationStores.js                
[npmPack] npm notice 803B    esm/models/configurationStoresMappers.js             
[npmPack] npm notice 345B    esm/models/index.js                                  
[npmPack] npm notice 506B    esm/operations/index.js                              
[npmPack] npm notice 25.6kB  esm/models/mappers.js                                
[npmPack] npm notice 3.4kB   esm/operations/operations.js                         
[npmPack] npm notice 542B    esm/models/operationsMappers.js                      
[npmPack] npm notice 2.4kB   esm/models/parameters.js                             
[npmPack] npm notice 9.8kB   esm/operations/privateEndpointConnections.js         
[npmPack] npm notice 696B    esm/models/privateEndpointConnectionsMappers.js      
[npmPack] npm notice 4.0kB   esm/operations/privateLinkResources.js               
[npmPack] npm notice 467B    esm/models/privateLinkResourcesMappers.js            
[npmPack] npm notice 1.0kB   rollup.config.js                                     
[npmPack] npm notice 1.7kB   package.json                                         
[npmPack] npm notice 457B    tsconfig.json                                        
[npmPack] npm notice 758B    esm/appConfigurationManagementClient.d.ts.map        
[npmPack] npm notice 912B    esm/appConfigurationManagementClient.js.map          
[npmPack] npm notice 530B    esm/appConfigurationManagementClientContext.d.ts.map 
[npmPack] npm notice 1.4kB   esm/appConfigurationManagementClientContext.js.map   
[npmPack] npm notice 170.7kB dist/arm-appconfiguration.js.map                     
[npmPack] npm notice 23.8kB  dist/arm-appconfiguration.min.js.map                 
[npmPack] npm notice 5.2kB   esm/operations/configurationStores.d.ts.map          
[npmPack] npm notice 8.6kB   esm/operations/configurationStores.js.map            
[npmPack] npm notice 423B    esm/models/configurationStoresMappers.d.ts.map       
[npmPack] npm notice 436B    esm/models/configurationStoresMappers.js.map         
[npmPack] npm notice 11.1kB  esm/models/index.d.ts.map                            
[npmPack] npm notice 206B    esm/operations/index.d.ts.map                        
[npmPack] npm notice 126B    esm/models/index.js.map                              
[npmPack] npm notice 221B    esm/operations/index.js.map                          
[npmPack] npm notice 1.5kB   esm/models/mappers.d.ts.map                          
[npmPack] npm notice 14.5kB  esm/models/mappers.js.map                            
[npmPack] npm notice 1.5kB   esm/operations/operations.d.ts.map                   
[npmPack] npm notice 2.1kB   esm/operations/operations.js.map                     
[npmPack] npm notice 244B    esm/models/operationsMappers.d.ts.map                
[npmPack] npm notice 257B    esm/models/operationsMappers.js.map                  
[npmPack] npm notice 588B    esm/models/parameters.d.ts.map                       
[npmPack] npm notice 1.7kB   esm/models/parameters.js.map                         
[npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
[npmPack] npm notice 4.2kB   esm/operations/privateEndpointConnections.js.map     
[npmPack] npm notice 365B    esm/models/privateEndpointConnectionsMappers.d.ts.map
[npmPack] npm notice 378B    esm/models/privateEndpointConnectionsMappers.js.map  
[npmPack] npm notice 1.7kB   esm/operations/privateLinkResources.d.ts.map         
[npmPack] npm notice 2.2kB   esm/operations/privateLinkResources.js.map           
[npmPack] npm notice 225B    esm/models/privateLinkResourcesMappers.d.ts.map      
[npmPack] npm notice 238B    esm/models/privateLinkResourcesMappers.js.map        
[npmPack] npm notice 3.4kB   README.md                                            
[npmPack] npm notice 1.3kB   esm/appConfigurationManagementClient.d.ts            
[npmPack] npm notice 1.9kB   src/appConfigurationManagementClient.ts              
[npmPack] npm notice 848B    esm/appConfigurationManagementClientContext.d.ts     
[npmPack] npm notice 2.3kB   src/appConfigurationManagementClientContext.ts       
[npmPack] npm notice 15.3kB  esm/operations/configurationStores.d.ts              
[npmPack] npm notice 28.6kB  src/operations/configurationStores.ts                
[npmPack] npm notice 493B    esm/models/configurationStoresMappers.d.ts           
[npmPack] npm notice 790B    src/models/configurationStoresMappers.ts             
[npmPack] npm notice 33.2kB  esm/models/index.d.ts                                
[npmPack] npm notice 190B    esm/operations/index.d.ts                            
[npmPack] npm notice 31.8kB  src/models/index.ts                                  
[npmPack] npm notice 474B    src/operations/index.ts                              
[npmPack] npm notice 2.0kB   esm/models/mappers.d.ts                              
[npmPack] npm notice 20.3kB  src/models/mappers.ts                                
[npmPack] npm notice 3.5kB   esm/operations/operations.d.ts                       
[npmPack] npm notice 6.8kB   src/operations/operations.ts                         
[npmPack] npm notice 232B    esm/models/operationsMappers.d.ts                    
[npmPack] npm notice 510B    src/models/operationsMappers.ts                      
[npmPack] npm notice 692B    esm/models/parameters.d.ts                           
[npmPack] npm notice 2.4kB   src/models/parameters.ts                             
[npmPack] npm notice 7.8kB   esm/operations/privateEndpointConnections.d.ts       
[npmPack] npm notice 14.3kB  src/operations/privateEndpointConnections.ts         
[npmPack] npm notice 386B    esm/models/privateEndpointConnectionsMappers.d.ts    
[npmPack] npm notice 664B    src/models/privateEndpointConnectionsMappers.ts      
[npmPack] npm notice 4.7kB   esm/operations/privateLinkResources.d.ts             
[npmPack] npm notice 8.6kB   src/operations/privateLinkResources.ts               
[npmPack] npm notice 157B    esm/models/privateLinkResourcesMappers.d.ts          
[npmPack] npm notice 419B    src/models/privateLinkResourcesMappers.ts            
[npmPack] npm notice 1.1kB   LICENSE.txt                                          
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-appconfiguration             
[npmPack] npm notice version:       1.2.0                                   
[npmPack] npm notice filename:      azure-arm-appconfiguration-1.2.0.tgz    
[npmPack] npm notice package size:  68.6 kB                                 
[npmPack] npm notice unpacked size: 633.5 kB                                
[npmPack] npm notice shasum:        08615dfdaec1624e72e3bf37df53d6ee02899527
[npmPack] npm notice integrity:     sha512-5b5bZ+7xoyMFK[...]wtXY1lcJwXf+A==

openapi-sdkautomation · 2020-08-14T21:18:24Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1803: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 18 Aug 2020 04:07:54 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0405:1362:12BBD4:2AA353:5F3B541A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4930","x-ratelimit-reset":"1597727246","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-appconfiguration@10479","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1802: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 18 Aug 2020 04:07:54 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0404:60F1:31D2B5:54D99C:5F3B541A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4929","x-ratelimit-reset":"1597727246","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-appconfiguration@10479","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}

️✔️azure-mgmt-appconfiguration [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-appconfiguration
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-appconfiguration
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] You must give at least one requirement to install (see "pip help install")
[ChangeLog] Size of delta 1.085% size of original (original: 17699 chars, delta: 192 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ConfigurationStoreUpdateParameters has a new parameter public_network_access

openapi-sdkautomation · 2020-08-14T21:18:25Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AppConfiguration [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-08-14T21:19:00Z

azure-sdk-for-python-track2 - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5107876 with merge commit d302c82. SDK Automation 13.0.17.20200807.2

[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'

️✔️azure-mgmt-appconfiguration [View full logs] [Release SDK Changes]

[build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf] INFO:packaging_tools:Building template azure-mgmt-appconfiguration
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-appconfiguration
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-08-14T21:19:00Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5107876 with merge commit d302c82. Schema Automation 13.0.17.20200807.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-14T21:20:02Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Add publicNetworkAccess property to ConfigurationStorePropertiesUpdat…

5107876

…eParameters

openapi-assignment-bot bot assigned erich-wang Aug 14, 2020

erich-wang approved these changes Aug 18, 2020

View reviewed changes

erich-wang merged commit d302c82 into Azure:master Aug 18, 2020

avanigupta deleted the avanigupta/updatepublicnetworkaccess branch August 28, 2020 19:11

avanigupta mentioned this pull request Aug 28, 2020

[AppConfig] Adding new parameter 'PublicNetworkAccess' for ConfigurationStoreUpdateParameters Azure/azure-sdk-for-net#14682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AppConfiguration] Added missing "publicNetworkAccess" property for patch request #10479

[AppConfiguration] Added missing "publicNetworkAccess" property for patch request #10479

avanigupta commented Aug 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 14, 2020 •

edited

Loading

azure-pipelines bot commented Aug 14, 2020

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

azuresdkci commented Aug 14, 2020

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

[AppConfiguration] Added missing "publicNetworkAccess" property for patch request #10479

[AppConfiguration] Added missing "publicNetworkAccess" property for patch request #10479

Conversation

avanigupta commented Aug 14, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 14, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 14, 2020

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

Azure CLI Extension Generation - Release

azuresdkci commented Aug 14, 2020

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Aug 14, 2020 • edited Loading

Trenton Generation - Release

avanigupta commented Aug 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2020 •

edited

Loading