Added Extended location property to Microsoft.Compute VM, VMSS & Image Resources and edgeZone parameter for image discovery APIs #11199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanrachapudy
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-python
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-resource-manager-schemas
|
Specs here: Introducing the new top property “extendedLocation” which is a complex property with its own “type” and “name” properties. Presumably there will be other extended location types, but its not clear which ones will have relevance to Microsoft.Compute. Currently the only type that is supported in “EdgeZone”. |
This was referenced Oct 14, 2020
|
Comment was made before the most recent commit for PR 11199 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
yungezz
approved these changes
Oct 21, 2020
|
hi @PhoenixHe-msft could you pls help to look at SDK Net task failure? thanks. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=583024&view=logs&j=b6885ff5-5b63-57e7-07bc-9d8d90d734f1&t=edefe71f-a8fe-52c2-c45d-59609a33c1f2 |
|
hi @pavanrachapudy is this PR ready to merge? SDK NET failure isn't a required CI task |
Seems to be related to run commands?
|
Add edgeZone parameter for image discovery APIs
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavanrachapudy
changed the title
|
@yungezz Updated the existing PR with image discovery APIs for edge zone as well. It will be great if you can review this as well. |
sure. this latest change adding new APIs, will add |
yungezz
added
the
WaitForARMFeedback
pilor
added
ARMSignedOff
pilor
approved these changes
Oct 22, 2020
|
@DwayneNeed It's related to test project build failure. I think you can ignore this now. |
|
hi @pavanrachapudy , is this PR ready to merge, that means service change is on Prod already. |
ping for update. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sandido
approved these changes
Oct 26, 2020
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.