DiskRP Swagger for 09/30 #11202
Merged
DiskRP Swagger for 09/30 #11202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlzhang
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'GallerySharingProfile_Update' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.Compute/preview/2020-09-30/gallery.json#L1637 |
|
| 'PUT' operation 'DiskAccesses_UpdateAPrivateEndpointConnection' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.Compute/stable/2020-09-30/disk.json#L1367 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. New: Microsoft.Compute/preview/2020-09-30/gallery.json#L1632 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.Compute/stable/2020-09-30/disk.json#L1563 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DiskRestorePointModel'. Consider using the plural form of 'DiskRestorePoint' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.Compute/stable/2020-09-30/disk.json#L1611 |
|
| OperationId should contain the verb: 'share' in:'GallerySharingProfile_Update'. Consider updating the operationId New: Microsoft.Compute/preview/2020-09-30/gallery.json#L1637 |
|
| The child tracked resource, 'hosts' with immediate parent 'DedicatedHostGroup', must have a list by immediate parent operation. New: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1346 |
|
| The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation. New: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1346 |
|
| The child tracked resource, 'extensions' with immediate parent 'VirtualMachineScaleSet', must have a list by immediate parent operation. New: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1346 |
|
| The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation. New: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1346 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-10-01-preview |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 18 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2016-04-30-preview/disk.json <---> new: stable/2020-09-30/disk.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-06-30/disk.json <---> new: stable/2020-09-30/disk.json
| Rule | Message |
|---|---|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2020-09-30/disk.json#L2899:11 Old: Microsoft.Compute/stable/2020-06-30/disk.json#L2505:11 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Compute/stable/2020-09-30/disk.json#L2873:5 Old: Microsoft.Compute/stable/2020-06-30/disk.json#L2475:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
This was referenced Jan 14, 2021
|
@yungezz , this PR re-introduced the preview version of the Gallery API, 2020-09-30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.