-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix servicefabric allOf and duplicate Operations_List #11581
Conversation
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.ServiceFabric/operations' does not match the ARM specification. Please standardize the schema. New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L342 |
️❌
~[Staging] Avocado: 1 Errors, 1 Warnings failed [Detail] [Expand]
Rule | Message |
---|---|
UNREFERENCED_JSON_FILE |
The example JSON file is not referenced from the swagger file. readme: specification/servicefabric/resource-manager/readme.md json: preview/2020-01-01-preview/examples/Operations_example.json |
The default tag contains multiple API versions swaggers. readme: specification/servicefabric/resource-manager/readme.md tag: specification/servicefabric/resource-manager/readme.md#tag-package-2020-03 |
️️✔️
~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️
~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️
~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️
~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-java
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@ctaggart please fix the CI errors , then we can go on reviewing |
I was just trying to help, but I ran out of time to contribute here. I'll reopen if I find more time to help out. |
It appears to be some mistakes using
allOf
in a few places.Operations_List
is also duplicated. This fixes both issues so that a code generator I'm using works.