Fix swagger correctness. #11839
Merged
Fix swagger correctness. #11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isResolveRequired New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1238 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Swagger Generation Artifacts
|
This was referenced Nov 27, 2020
innosam
force-pushed
the
hsingh/fixswaggercorrectness
branch
from
386451d
to
a6c7f2b
Compare
dukum
approved these changes
Dec 1, 2020
innosam
commented
Dec 2, 2020
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Outdated
Show resolved
Hide resolved
innosam
commented
Dec 2, 2020
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Outdated
Show resolved
Hide resolved
innosam
force-pushed
the
hsingh/fixswaggercorrectness
branch
from
a6c7f2b
to
db47200
Compare
ajaygit158
reviewed
Dec 2, 2020
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@akning-ms Would you please help to merge this PR? The fix will be released on monday but PR author need to merge it now. |
ChenTanyi
approved these changes
Dec 4, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@innosam please resolve the conflict. Thanks. |
Done, thanks! |
|
@innosam Are you still need it? |
ChenTanyi
reviewed
Dec 8, 2020
| @@ -1531,6 +1550,19 @@ | |||
| "description": "Gets the value of next link.", | |||
| "type": "string" | |||
| }, | |||
| "summary": { | |||
There was a problem hiding this comment.
Will the summary be still needed? compared with the previous change: 0d41369
There was a problem hiding this comment.
@innosam You may need to take a look at it. It will cause lots of error in CI.
There was a problem hiding this comment.
yes, I am looking into the issue, looks like the earlier there was a breaking issue, which has been fixed by durgesh.
There was a problem hiding this comment.
I have fixed the issue now, and pr is green.
1. Add missing properties: isResolveRequired, totalCount read-only property to the moveResource and moveResourceCollection definition. 2. Add missing properties: ETAG/properties.errors property to the move collection definition.
innosam
force-pushed
the
hsingh/fixswaggercorrectness
branch
from
9934f23
to
580aa44
Compare
This was referenced Dec 8, 2020
Closed
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
1. Add missing properties: isResolveRequired, totalCount read-only property to the moveResource and moveResourceCollection definition. 2. Add missing properties: ETAG/properties.errors property to the move collection definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property to the moveResource and moveResourceCollection definition.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.