Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Resource NetworkManager #12441

Merged
merged 58 commits into from
Feb 24, 2021
Merged

Add New Resource NetworkManager #12441

merged 58 commits into from
Feb 24, 2021

Conversation

yanfa317
Copy link
Contributor

@yanfa317 yanfa317 commented Jan 14, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @yanfa317 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 14, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 11 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'SecurityConfigurations_EvaluateImport' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManagerSecurityConfiguration.json#L146
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'NetworkManagers_PatchTags' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L151
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkManagerDeploymentStatusModel'. Consider using the plural form of 'NetworkManagerDeploymentStatus' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L254
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'commit' in:'NetworkManagerCommits_Post'. Consider updating the operationId
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L204
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listdeploymentstatus' in:'NetworkManagerDeploymentStatus_List'. Consider updating the operationId
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L254
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'EffectiveVirtualNetworks_ListByNetworkManager'. Consider updating the operationId
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L395
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'EffectiveVirtualNetworks_ListByNetworkGroup'. Consider updating the operationId
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManagerGroup.json#L227
    ⚠️ R4021 - DescriptionAndTitleMissing 'deploymentType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L647
    ⚠️ R4021 - DescriptionAndTitleMissing 'connectivityGroupItem' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManagerConnectivityConfiguration.json#L292
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Network Manager
    Location: Microsoft.Network/preview/2021-02-01-preview/networkManager.json#L443
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/network/resource-manager/readme.md
    tag: specification/network/resource-manager/readme.md#tag-package-2021-02-preview
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 100 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L39:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L172:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Network/applicationGateways' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L207:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/start' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L235:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/stop' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L272:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}/' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L312:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}arpTable' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L445:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}routesTable' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L487:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}stats' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L529:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits' removed or restructured?
    Old: Microsoft.Network/preview/2015-05-01-preview/network.json#L571:5
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 3 Errors, 16755 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ PreCheck/DuplicateSchema "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:3788" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ PreCheck/DuplicateSchema "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:3792" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ AutorestCore/Exception "readme":"network/resource-manager/readme.md",
    "tag":"package-2021-02-preview",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayOnDemandProbe' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayBackendHealthOnDemand' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayBackendHealth' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayBackendHealthPool' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayBackendHealthHttpSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewayBackendHealthServer' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"network/resource-manager/readme.md",
    "tag":"package-2020-08",
    "details":"The schema 'ApplicationGatewaySku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 14, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 36b9a02. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-24 07:31:04 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated"
cmderr	[generate.py] 2021-02-24 07:31:04 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-24 07:31:04 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-24 07:34:42 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-02-24 07:35:54 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-24 07:37:16 DEBUG Got artifact_id: azure-resourcemanager-network-generated
cmderr	[Inst] 2021-02-24 07:37:16 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-24 07:37:16 ERROR Unmatch any jar in artifacts
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 36b9a02. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
cmderr	[npmPack] created ./dist/arm-network.js in 2.6s
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 36b9a02. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 36b9a02. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-network [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model NetworkInterface has a new parameter private_link_service
info	[Changelog]   - Model NetworkInterface has a new parameter migration_phase
info	[Changelog]   - Model NetworkInterface has a new parameter nic_type
info	[Changelog]   - Model NetworkInterfaceIPConfiguration has a new parameter type
info	[Changelog]   - Model PublicIPPrefix has a new parameter nat_gateway
info	[Changelog]   - Model Subnet has a new parameter type
info	[Changelog]   - Model Subnet has a new parameter application_gateway_ip_configurations
info	[Changelog]   - Model PublicIPAddress has a new parameter nat_gateway
info	[Changelog]   - Model PublicIPAddress has a new parameter migration_phase
info	[Changelog]   - Model PublicIPAddress has a new parameter linked_public_ip_address
info	[Changelog]   - Model PublicIPAddress has a new parameter service_public_ip_address
info	[Changelog]   - Model Delegation has a new parameter type
info	[Changelog]   - Model VirtualNetworkPeering has a new parameter type
info	[Changelog]   - Model VirtualNetworkPeering has a new parameter do_not_verify_remote_gateways
info	[Changelog]   - Model VirtualNetworkPeering has a new parameter resource_guid
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @yanfa317, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 14, 2021
    Closed
    This was referenced Jan 15, 2021
    Closed
    Closed
    This was referenced Jan 15, 2021
    Draft
    Closed
    This was referenced Feb 24, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @yanfa317 @mkarmark
    Add New Resource NetworkManager (Azure#12441)
    bd60358 
    * Add New Resource NetworkManager

* fix prettie

* Fix bug

* add customwords

* fix bugs

* add patch api

* Fix bug

* add deployment status apis

* fix bugs

* Fix bugs

* fix bug

* add vnetapi

* Fix bug

* Fix bug

* prettycheck

* fix bug

* fix as commnets

* fix example

* fix buyg

* Fix as commit

* fix bug

* move to preview folder

* Fix bug

* fix bug

* Fix description

* Fix bug

* fix bug

* fix rules

* fix spell

* Remove tags and add systemtags

* Fix bug

* remove location

* fix as discussed

* Fix bug

* Fix version

* fix as commnets

* Fix format

* fix format

* fix bug

* Add patch nm

* Fix bug

* fix validation

* update tag

* Fix as commnets

* fix bug

* Fix Bug Issue

* Fix Bug Issue

* Fix dup

* Fix dup

* New fix

* add systemdata

* add systemdata

* Change as comments

* fix as comments

* try unchange tag

* change tag
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mohnader mohnader mohnader left review comments

    @RamyasreeChakka RamyasreeChakka RamyasreeChakka left review comments

    @nipati-p nipati-p nipati-p left review comments

    @divega divega divega approved these changes

    @lirenhe lirenhe lirenhe approved these changes

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    Assignees

    @jorgecotillo jorgecotillo

    @lirenhe lirenhe

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    9 participants
    @yanfa317 @RamyasreeChakka @ruowan @jorgecotillo @zhenglaizhang @lirenhe @divega @mohnader @nipati-p