APIM Missing Operations reported in S360 #12621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @solankisamir Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'PortalSettings_ListByService' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimportalsettings.json#L38 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3836 |
|
| The resource 'PortalSettingsContract' does not have get operation, please add it. New: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L3802 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
Hi, @solankisamir your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @raych1 |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
NewApiVersionRequired reason: |
|
Hi @solankisamir, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 25, 2021
openapi-pipeline-app
bot
added
BreakingChangeReviewRequired
and removed
CI-FixRequiredOnFailure
labels
|
Hi @solankisamir, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Jan 25, 2021
|
@solankisamir , looks like this PR includes two parts changes. One is to fix s360 swagger kpi issue and the other is to add an new API. Can you separate this PR into two? The latter one needs ARM review. |
raych1
added
the
Reviewed-ChangesRequested
|
@raych1 bth these issues were caught by the S360 kpi.
|
pilor
removed
the
WaitForARMFeedback
pilor
added
the
ARMSignedOff
|
@raych1 can we merge this? |
@solankisamir , can you suppress lintDiff error if this API |
|
@raych1 |
solankisamir
force-pushed
the
apim-s360
branch
from
f0c9408
to
51e85a6
Compare
|
@raych1 can you take a look again? I have fixed all the Swagger Model issues and even added suppressions. |
raych1
removed
the
Reviewed-ChangesRequested
|
@raych1 can you take a look again? |
|
@raych1 we did not publish python sdk for preview api-version. I think we should be good! |
raych1
approved these changes
Feb 3, 2021
This was referenced Feb 3, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* missing operations * swagger linter issues * suppression * add count property * fix swagger model issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.