Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

Conversation

worldhello126
Copy link
Contributor

@worldhello126 worldhello126 commented Feb 1, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @worldhello126 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 14 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'ContainerGroupUsage_List' to 'Location_ListUsage'. This will impact generated code.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L452:7
    Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L290:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'ContainerLogs_List' to 'Containers_ListLogs'. This will impact generated code.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L491:7
    Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L320:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'StartContainer_LaunchExec' to 'Containers_ExecuteCommand'. This will impact generated code.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L550:7
    Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L367:7
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L61:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L101:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L147:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L200:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L248:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L286:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L292:11
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
    • ️✔️@azure/arm-containerinstance [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/containerInstanceManagementClient.js → ./dist/arm-containerinstance.js...
      cmderr	[npmPack] created ./dist/arm-containerinstance.js in 351ms
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-containerinstance [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model LogAnalytics has a new parameter workspace_resource_id
      info	[Changelog]   - Model ContainerHttpGet has a new parameter http_headers
      info	[Changelog]   - Added operation ContainersOperations.attach
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ContainersOperations.list_logs has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1f2f490. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
    • ️✔️containerinstance [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  [email protected] No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️containerinstance/mgmt/2020-11-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️containerinstance/mgmt/2019-12-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerinstance/mgmt/2018-10-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerinstance/mgmt/2018-09-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerinstance/mgmt/2018-06-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerinstance/mgmt/2018-04-01/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerinstance/mgmt/2018-02-01-preview/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerinstance/mgmt/2017-12-01-preview/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerinstance/mgmt/2017-10-01-preview/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerinstance/mgmt/2017-08-01-preview/containerinstance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-04 01:23:13 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-containerinstance-generated"
      cmderr	[generate.py] 2021-02-04 01:23:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-04 01:23:13 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/containerinstance/azure-resourcemanager-containerinstance-generated --java.namespace=com.azure.resourcemanager.containerinstance.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Skip] pom already has module azure-resourcemanager-containerinstance-generated
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-containerinstance-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact_id: azure-resourcemanager-containerinstance-generated
      cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Match jar package: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-04 01:26:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12765/azure-sdk-for-java/azure-resourcemanager-containerinstance-generated/azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-containerinstance-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @worldhello126
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-workflow-bot
    Copy link

    Hi, @worldhello126 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @PhoenixHe-msft

    @jorgecotillo jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 2, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    … version stable/2021-03-01 (Azure#12765)
    
    * Adds base for updating Microsoft.ContainerInstance from version stable/2020-11-01 to version 2021-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants