updated ErrorResponse in DataExport and OperationStatuses #13012

dabenhamMic · 2021-02-17T15:06:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-17T15:06:44Z

Hi, @dabenhamMic Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-17T15:06:45Z

Swagger Validation Report

️❌BreakingChange: 31 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-08-01/Clusters.json <---> new: stable/2020-08-01/Clusters.json
- original: stable/2020-08-01/DataExports.json <---> new: stable/2020-08-01/DataExports.json
- original: stable/2020-08-01/OperationStatuses.json <---> new: stable/2020-08-01/OperationStatuses.json
- original: stable/2020-08-01/Tables.json <---> new: stable/2020-08-01/Tables.json

Rule	Message
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L69:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L69:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L108:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L108:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L178:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L178:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L223:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L223:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L268:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L268:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L321:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L321:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L72:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L72:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L142:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L142:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L189:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L189:13
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L236:13 Old: Microsoft.OperationalInsights/stable/2020-08-01/DataExports.json#L236:13

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- operationalinsights/resource-manager/readme.md tag:package-2020-10
- operationalinsights/resource-manager/readme.md tag:package-2020-08
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- operationalinsights/resource-manager/readme.md tag:package-2020-10
- operationalinsights/resource-manager/readme.md tag:package-2020-08

Rule	Message
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get specific operation status Location: Microsoft.OperationalInsights/stable/2020-10-01/Operations.json#L39

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2020-10

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 143 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'Destination' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DestinationMetaData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'IntelligencePack' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'LinkedServiceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-17T15:06:46Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 33ffbed. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️operationalinsights/mgmt/2020-10-01/operationalinsights [View full logs] [Release SDK Changes]

Only show 24 items here, please refer to log for details.

info	[Changelog] - New struct `StorageInsight`
info	[Changelog] - New struct `StorageInsightConfigsClient`
info	[Changelog] - New struct `StorageInsightListResult`
info	[Changelog] - New struct `StorageInsightListResultIterator`
info	[Changelog] - New struct `StorageInsightListResultPage`
info	[Changelog] - New struct `StorageInsightProperties`
info	[Changelog] - New struct `StorageInsightStatus`
info	[Changelog] - New struct `Table`
info	[Changelog] - New struct `TableProperties`
info	[Changelog] - New struct `TablesClient`
info	[Changelog] - New struct `TablesListResult`
info	[Changelog] - New struct `Tag`
info	[Changelog] - New struct `UsageMetric`
info	[Changelog] - New struct `UsagesClient`
info	[Changelog] - New struct `WorkspaceListManagementGroupsResult`
info	[Changelog] - New struct `WorkspaceListUsagesResult`
info	[Changelog] - New struct `WorkspacePurgeBody`
info	[Changelog] - New struct `WorkspacePurgeBodyFilters`
info	[Changelog] - New struct `WorkspacePurgeClient`
info	[Changelog] - New struct `WorkspacePurgeResponse`
info	[Changelog] - New struct `WorkspacePurgeStatusResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 446 additive change(s).
info	[Changelog]

️✔️operationalinsights/mgmt/2020-08-01/operationalinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `ClusterErrorResponse` has been removed
info	[Changelog] - Struct `DataExportErrorResponse` has been removed
info	[Changelog] - Struct `ErrorContract` has been removed
info	[Changelog] - Field `Target` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Details` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `AdditionalInfo` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Code` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Message` of struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 3 additive change(s).
info	[Changelog]

️✔️operationalinsights/mgmt/2015-03-20/operationalinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/operationalinsights/mgmt/2020-03-01-preview/operationalinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/operationalinsights/mgmt/2015-11-01-preview/operationalinsights [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 33ffbed. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.OperationalInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.OperationalInsights.0.21.0-preview.nupkg
- Microsoft.Azure.Management.OperationalInsights.0.21.0-preview.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 33ffbed. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md

️✔️@azure/arm-operationalinsights [View full logs] [Release SDK Changes]

azure-arm-operationalinsights-5.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/operationalInsightsManagementClient.js → ./dist/arm-operationalinsights.js...
cmderr	[npmPack] created ./dist/arm-operationalinsights.js in 577ms

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 33ffbed. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 33ffbed. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md

️✔️operationalinsights [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] npm WARN [email protected] No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 33ffbed. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-23 23:09:10 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-loganalytics;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 23:09:10 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 23:09:10 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/loganalytics/azure-resourcemanager-loganalytics --java.namespace=com.azure.resourcemanager.loganalytics   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-loganalytics
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Skip] pom already has module azure-resourcemanager-loganalytics
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Skip] pom already has module sdk/loganalytics
cmderr	[generate.py] 2021-02-23 23:09:53 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-loganalytics [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-23 23:12:42 DEBUG Got artifact_id: azure-resourcemanager-loganalytics
cmderr	[Inst] 2021-02-23 23:12:42 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-23 23:12:42 DEBUG Got artifact: azure-resourcemanager-loganalytics-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-02-23 23:12:42 DEBUG Got artifact: azure-resourcemanager-loganalytics-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 23:12:42 DEBUG Match jar package: azure-resourcemanager-loganalytics-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 23:12:42 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13012/azure-sdk-for-java/azure-resourcemanager-loganalytics/azure-resourcemanager-loganalytics-1.0.0-beta.2.jar\" -o azure-resourcemanager-loganalytics-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-loganalytics -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-loganalytics-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-17T15:08:32Z

Hi @dabenhamMic, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-02-17T15:10:02Z

Hi @dabenhamMic, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

markcowl · 2021-02-17T22:15:00Z

/azp run

azure-pipelines · 2021-02-17T22:15:14Z

Azure Pipelines successfully started running 2 pipeline(s).

dabenhamMic · 2021-02-18T11:49:03Z

@markcowl we have changed the contract from custom definition error response to common ErrorResponse.
this was done in order to pass the validation tests and generate a new SDK for Microsoft.OperationalInsights.

markcowl · 2021-02-19T20:21:39Z

@dabenhamMic Was this done in response to an s360 issue on swagger correctness or completeness? If so, link it here, and we may be able to approve without the breaking chaneg review.

Otherwise, breaking change review is required, even for 'good' changes. 'good' changes may be approved.

ArcturusZhang · 2021-02-23T07:39:14Z

Hi @akning-ms could you help on this breaking change warning? This PR only replace the self-defined error model with the error model defined in common-types, which is not really a breaking change, I suppose.

akning-ms · 2021-02-23T09:18:42Z

Hi @akning-ms could you help on this breaking change warning? This PR only replace the self-defined error model with the error model defined in common-types, which is not really a breaking change, I suppose.

Yes. looks a false alarm. it is due to a extra type: object in old version. + @jianyexi for awareness

jianyexi · 2021-02-23T09:21:07Z

Hi @akning-ms
        Arthur Ning
        FTE could you help on this breaking change warning? This PR only replace the self-defined error model with the error model defined in common-types, which is not really a breaking change, I suppose.
Yes. looks a false alarm. it is due to a extra type: object in old version. + @jianyexi Jianye Xi FTE for awareness

Agreed, this change has no impact, can be approved safely.

dabenhamMic · 2021-02-23T10:16:30Z

@markcowl , @jianyexi , can one of you guys please approve and merge this pr?

markcowl · 2021-02-23T19:48:15Z

@jianyexi Change from a locally defined schema to the common schema automatically changes types in any strongly typed language SDK. This may have been done for good reason, but it is a breaking change in the api definition

jianyexi · 2021-02-24T03:56:00Z

@jianyexi Jianye Xi FTE Change from a locally defined schema to the common schema automatically changes types in any strongly typed language SDK. This may have been done for good reason, but it is a breaking change in the api definition

Since the autorest modeler4 can auto-corrected the undefined type to "'type:object'" , and the model name and its definition are not changed, why there are breaking change ? The SDK generation even don't know this change 's happen .

* updated ErrorResponse in DataExport and OperationStatuses * removed whitespace * fixed ErrorResponse in Cluster 2020-08-01 * ErrorResponse in Tables.json 2020-08-01 * changed min retention of TablesList to 30 from 7

updated ErrorResponse in DataExport and OperationStatuses

eba0111

openapi-assignment-bot bot assigned markcowl Feb 17, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 17, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Feb 17, 2021

openapi-sdkautomation bot mentioned this pull request Feb 17, 2021

[AutoPR azure-resourcemanager-loganalytics] updated ErrorResponse in DataExport and OperationStatuses AzureSDKAutomation/azure-sdk-for-java#7515

Closed

removed whitespace

98372f5

markcowl closed this Feb 17, 2021

markcowl reopened this Feb 17, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 17, 2021

fixed ErrorResponse in Cluster 2020-08-01

d607bc3

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 18, 2021

ErrorResponse in Tables.json 2020-08-01

972ee08

openapi-pipeline-app bot added CI-FixRequiredOnFailure CI-BreakingChange-Go and removed CI-FixRequiredOnFailure labels Feb 18, 2021

changed min retention of TablesList to 30 from 7

1ebde9c

dabenhamMic mentioned this pull request Feb 23, 2021

New package for publishing OperationalInsights SDK #12886

Closed

25 tasks

kairu-ms requested a review from yoramsinger February 23, 2021 08:41

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 23, 2021

JeffreyRichter approved these changes Feb 23, 2021

View reviewed changes

markcowl merged commit 33ffbed into Azure:master Feb 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated ErrorResponse in DataExport and OperationStatuses #13012

updated ErrorResponse in DataExport and OperationStatuses #13012

dabenhamMic commented Feb 17, 2021 •

edited by markcowl

Loading

openapi-workflow-bot bot commented Feb 17, 2021

openapi-pipeline-app bot commented Feb 17, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 17, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 17, 2021

openapi-workflow-bot bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

dabenhamMic commented Feb 18, 2021

markcowl commented Feb 19, 2021

ArcturusZhang commented Feb 23, 2021

akning-ms commented Feb 23, 2021

jianyexi commented Feb 23, 2021

dabenhamMic commented Feb 23, 2021

markcowl commented Feb 23, 2021 •

edited

Loading

jianyexi commented Feb 24, 2021 •

edited

Loading

updated ErrorResponse in DataExport and OperationStatuses #13012

updated ErrorResponse in DataExport and OperationStatuses #13012

Conversation

dabenhamMic commented Feb 17, 2021 • edited by markcowl Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 17, 2021

openapi-pipeline-app bot commented Feb 17, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 17, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 17, 2021

openapi-workflow-bot bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

dabenhamMic commented Feb 18, 2021

markcowl commented Feb 19, 2021

ArcturusZhang commented Feb 23, 2021

akning-ms commented Feb 23, 2021

jianyexi commented Feb 23, 2021

dabenhamMic commented Feb 23, 2021

markcowl commented Feb 23, 2021 • edited Loading

jianyexi commented Feb 24, 2021 • edited Loading

dabenhamMic commented Feb 17, 2021 •

edited by markcowl

Loading

openapi-pipeline-app bot commented Feb 17, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 17, 2021 •

edited

Loading

markcowl commented Feb 23, 2021 •

edited

Loading

jianyexi commented Feb 24, 2021 •

edited

Loading