Adding new api version- 2021-03-08 #13524

renu00 · 2021-03-19T18:42:23Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-03-19T18:42:27Z

Hi, @renu00 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

ghost · 2021-03-19T18:42:29Z

Thank you for your contribution renu00! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2021-03-19T18:42:29Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 28 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
- applicationinsights/resource-manager/readme.md tag:package-2021-03-08
Linted configuring files (Based on target branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
- applicationinsights/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1005 - GetInOperationName	'GET' operation 'Workbooks_RevisionsList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L337
⚠️ R1005 - GetInOperationName	'GET' operation 'Workbooks_RevisionGet' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L379
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L697
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'ComponentCurrentBillingFeatures_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json#L38
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'ComponentAvailableFeatures_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json#L177
⚠️ R4021 - DescriptionAndTitleMissing	'Properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L269
⚠️ R4021 - DescriptionAndTitleMissing	'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json#L385
⚠️ R4021 - DescriptionAndTitleMissing	'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json#L416
⚠️ R4021 - DescriptionAndTitleMissing	'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L484
⚠️ R4021 - DescriptionAndTitleMissing	'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L515

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Insights/operations' does not match the ARM specification. Please standardize the schema. Location: azure-rest-api-specs/blob/d187dd4fc3d8064504d93335efb63e5c706a36b5/undefined#Lundefined

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 8 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.8.8)
- original: preview/2018-06-17-preview/workbookOperations_API.json <---> new: stable/2021-03-08/workbookOperations_API.json
- original: preview/2018-06-17-preview/workbooks_API.json <---> new: stable/2021-03-08/workbooks_API.json

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' removed or restructured? Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L37:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' removed or restructured? Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L88:5
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L458:9 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L307:9
⚠️ 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L458:9 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L307:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'kind' renamed or removed? New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L421:7 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L271:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L649:7 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L466:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L649:7 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L466:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'details' renamed or removed? New: Microsoft.Insights/stable/2021-03-08/workbooks_API.json#L649:7 Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L466:7

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.8)
- original: stable/2020-10-20/myworkbooks_API.json <---> new: stable/2021-03-08/myworkbooks_API.json
- original: stable/2020-10-20/workbookOperations_API.json <---> new: stable/2021-03-08/workbookOperations_API.json
- original: stable/2020-10-20/workbooks_API.json <---> new: stable/2021-03-08/workbooks_API.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌[Staging] SDK Track2 Validation: 3 Errors, 0 Warnings failed [Detail]

The following tags are being changed in this PR

applicationinsights/resource-manager/readme.md#package-2021-03-08

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2021-03-08", "details":"Duplicate Schema named ManagedIdentity -- properties.userAssignedIdentities.$ref: undefined => "#/components/schemas/schemas:350" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2021-03-08", "details":"Duplicate Schema named UserAssignedIdentities -- properties.clientId: undefined => "description":"The client ID of resource.", "readOnly":true, "$ref":"#/components/schemas/schemas:353" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2021-03-08", "details":"Error: Plugin prechecker reported failure."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-03-19T18:42:30Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️appinsights/mgmt/2015-05-01/insights [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md

️✔️@azure/arm-appinsights [View full logs] [Preview SDK Changes]

azure-arm-appinsights-3.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
cmderr	[npmPack] created ./dist/arm-appinsights.js in 205ms

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.ApplicationInsights [View full logs] [Preview SDK Changes]

cmdout	[msbuild]      1>/home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project.
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️❌ azure-sdk-for-python failed [Detail]

❌Failed [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!Error happened during package
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-applicationinsights [View full logs] [Preview SDK Changes]
- azure-mgmt-applicationinsights-1.0.0.zip
- azure_mgmt_applicationinsights-1.0.0-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-02 03:24:51 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-applicationinsights"
cmderr	[generate.py] 2021-04-02 03:24:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-04-02 03:24:51 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/applicationinsights/azure-resourcemanager-applicationinsights --java.namespace=com.azure.resourcemanager.applicationinsights   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [POM][Skip] pom already has module azure-resourcemanager-applicationinsights
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-02 03:25:25 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-applicationinsights [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-04-02 03:28:46 DEBUG Got artifact_id: azure-resourcemanager-applicationinsights
cmderr	[Inst] 2021-04-02 03:28:46 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-02 03:28:46 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-02 03:28:46 DEBUG Match jar package: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-02 03:28:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13524/azure-sdk-for-java/azure-resourcemanager-applicationinsights/azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\" -o azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-applicationinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5ea1af51c29c39d600b496bc0bc5ed0340a50d78. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md

️✔️applicationinsights [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  [email protected] No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-03-19T18:44:18Z

Hi @renu00, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

…api-versions to 2021-03-08

openapi-workflow-bot · 2021-03-30T21:48:50Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

renu00 · 2021-03-30T22:39:48Z

Hey @lmazuel , Can you please review this PR?

…g their api-versions to 2021-03-08" This reverts commit 8abd9f1.

openapi-workflow-bot · 2021-04-02T03:25:04Z

Hi, @renu00 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @lmazuel

tonykslee · 2021-04-09T17:27:02Z

@akning-ms @lmazuel Since we are blocked on the ARM review, I went to go create an IcM as its written in the step above. however, it looks like the suggested Team "RP Manifest Approvers" doesn't exist under "Azure Resource Manager" service.

akning-ms · 2021-04-12T02:00:27Z

Hi @tonykslee, you don't need to create IcM ticket for ARM team. you can ping on-call person to help you review the PR.
You can find who is on call via below guide:
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

tonykslee · 2021-04-20T21:00:28Z

I've reposted this PR here to include a first commit with unmodified existing files #14041

Adding new api version- 2021-03-08

074b07f

renu00 requested review from hectorhdzg, lzchen, ramthi and trask as code owners March 19, 2021 18:42

openapi-assignment-bot bot assigned lmazuel Mar 19, 2021

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 19, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 19, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 19, 2021

This was referenced Mar 19, 2021

[AutoPR @azure/arm-appinsights] Adding new api version- 2021-03-08 AzureSDKAutomation/azure-sdk-for-js#4080

Draft

[AutoPR applicationinsights] Adding new api version- 2021-03-08 AzureSDKAutomation/azure-resource-manager-schemas#2015

Draft

Fixing validation issues

fcd3bb8

minor fixes

7d49f8c

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 29, 2021

Adding missing file

e091c6b

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 29, 2021

removed unaffected apis since they aren't going to be changing their …

8abd9f1

…api-versions to 2021-03-08

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 30, 2021

Merge branch 'renu/master' into users/rerani/newApiVersion

a8de75d

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 30, 2021

ran prettier check, added systemData to response

1482f5e

added path to systemData definition

7df5cc2

openapi-pipeline-app bot added NewApiVersionRequired and removed CI-FixRequiredOnFailure labels Mar 30, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 30, 2021

removed systemData

526f593

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure NewApiVersionRequired labels Mar 30, 2021

adding systemData to response

1f698ad

openapi-pipeline-app bot added NewApiVersionRequired CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 30, 2021

moved systemData, ran prettier

22600bb

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure NewApiVersionRequired labels Mar 30, 2021

lmazuel added the Reassign label Apr 1, 2021

Revert "removed unaffected apis since they aren't going to be changin…

d187dd4

…g their api-versions to 2021-03-08" This reverts commit 8abd9f1.

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 2, 2021

tonykslee assigned akning-ms Apr 2, 2021

tonykslee mentioned this pull request Apr 20, 2021

Users/tolee/new api version #14041

Merged

26 tasks

tonykslee closed this Apr 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding new api version- 2021-03-08 #13524

Adding new api version- 2021-03-08 #13524

renu00 commented Mar 19, 2021 •

edited by tonykslee

Loading

openapi-workflow-bot bot commented Mar 19, 2021

ghost commented Mar 19, 2021

openapi-pipeline-app bot commented Mar 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2021 •

edited

Loading

openapi-workflow-bot bot commented Mar 19, 2021

openapi-workflow-bot bot commented Mar 30, 2021

renu00 commented Mar 30, 2021

openapi-workflow-bot bot commented Apr 2, 2021

tonykslee commented Apr 9, 2021

akning-ms commented Apr 12, 2021

tonykslee commented Apr 20, 2021

Adding new api version- 2021-03-08 #13524

Adding new api version- 2021-03-08 #13524

Conversation

renu00 commented Mar 19, 2021 • edited by tonykslee Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 19, 2021

ghost commented Mar 19, 2021

openapi-pipeline-app bot commented Mar 19, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 19, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Mar 19, 2021

openapi-workflow-bot bot commented Mar 30, 2021

renu00 commented Mar 30, 2021

openapi-workflow-bot bot commented Apr 2, 2021

tonykslee commented Apr 9, 2021

akning-ms commented Apr 12, 2021

tonykslee commented Apr 20, 2021

renu00 commented Mar 19, 2021 •

edited by tonykslee

Loading

openapi-pipeline-app bot commented Mar 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 19, 2021 •

edited

Loading