-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-01-01 #13824
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-01-01 #13824
Conversation
…2020-12-01-preview to version 2021-01-01
Hi, @melmullen Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
The operation 'GenerateDetailedCostReportOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.generatedetailedcostreport.json#L123 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: direction Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L1286 |
|
OperationId should contain the verb: 'generatedetailedcostreport' in:'GenerateDetailedCostReport_CreateOperation'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.generatedetailedcostreport.json#L41 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: partitionData Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.exports.json#L547 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.exports.json#L270 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.CostManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L1103 |
Since operation 'Exports_GetExecutionHistory' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.exports.json#L342 |
|
Since operation 'Dimensions_ByExternalCloudProviderType' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L870 |
|
'GET' operation 'Dimensions_ByExternalCloudProviderType' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L870 |
|
'PATCH' operation 'Alerts_Dismiss' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L487 |
|
Based on the response model schema, operation 'Exports_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.exports.json#L37 |
|
Based on the response model schema, operation 'Exports_GetExecutionHistory' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-01-01/costmanagement.exports.json#L338 |
|
Based on the response model schema, operation 'Alerts_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L383 |
|
Based on the response model schema, operation 'Alerts_ListExternal' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L537 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/cost-management/resource-manager/readme.md tag: specification/cost-management/resource-manager/readme.md#tag-package-2021-01 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
️️✔️
Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
|
💬 AutorestCore/Exception | "readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi @melmullen, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @melmullen your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @qianwens |
No pipelines are associated with this pull request. |
...gement/stable/2021-01-01/examples/GenerateDetailedCostReportBySubscriptionAndTimePeriod.json
Outdated
Show resolved
Hide resolved
...gement/stable/2021-01-01/examples/GenerateDetailedCostReportBySubscriptionAndTimePeriod.json
Outdated
Show resolved
Hide resolved
specification/cost-management/resource-manager/readme.azureresourceschema.md
Show resolved
Hide resolved
…nt-Microsoft.CostManagement-2021-01-01
…nt-Microsoft.CostManagement-2021-01-01 # Conflicts: # specification/cost-management/resource-manager/readme.azureresourceschema.md # specification/cost-management/resource-manager/readme.md
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…rsion stable/2021-01-01 (Azure#13824) * Adds base for updating Microsoft.CostManagement from version preview/2020-12-01-preview to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * Latest * Latest * Latest * Latest * Latest * Latest * Latest * Latest
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.