-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add Extensions Async API and other fixes" #13972
Conversation
This reverts commit b78af6e.
Hi, @chunyu3 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Extensions_Create' is not read only. Please add the readonly for the systemData. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L38 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Extensions_Get' is not read only. Please add the readonly for the systemData. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L97 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Extensions_Update' is not read only. Please add the readonly for the systemData. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L147 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'SourceControlConfigurations_Get' is not read only. Please add the readonly for the systemData. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L38 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'SourceControlConfigurations_CreateOrUpdate' is not read only. Please add the readonly for the systemData. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L87 |
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create Extension Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L154 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Extension Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L213 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Source Control Configuration Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L209 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L500 |
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it. Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L426 |
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L634 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L564 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
️❌
Cross Version BreakingChange (Base on stable version): 12 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
Only 10 items are listed, please refer to log for more details.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
"tag":"package-2021-03",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
"tag":"package-2021-03",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi @chunyu3, Your PR has some issues. Please fix the CI sequentially by following the order of
|
f3dca56
into
dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview
…5 01 preview (#14302) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview * Updates readme * Updates API version in new specs and examples * Add Extensions Async API and other fixes (#13709) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Revert "Add Extensions Async API and other fixes (#13709)" (#13972) This reverts commit b78af6e. * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (#13992) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Remove extensions resource in the route of ListAsyncOperations at Cluster scope * Remove extension parameter in the spec * Remove extension parameter from route of ListAsycOperations * Add Origin property to Available Operations response body * Make Identity property nullable * Add Get, List Extension Types (#13562) * Add Get, List Extension Types * style check fixes * - update spec - rename and update example files - fix validation errors * fix examples * - update readme.md - generate example files with oav - try to fix some new validation errors * more validation fixes * add ExtensionTypeVersion_List * - update readme for SDKs - update examples * fix typo and linting * rename ExtensionTypeVersions_List * - address comments - update list extension versions based on location * fix list versions route * fix tag and unused parameters in spec file * fix autorest validatoin errors * udpate readme * update readme * try to fix sdk validation warnings * - prettier fix - revert changes to types.json * fix pageable missing itemName Co-authored-by: Carlo Cardella <[email protected]> Co-authored-by: chunyu3 <[email protected]>
…5 01 preview (Azure#14302) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview * Updates readme * Updates API version in new specs and examples * Add Extensions Async API and other fixes (Azure#13709) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972) This reverts commit b78af6e. * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Remove extensions resource in the route of ListAsyncOperations at Cluster scope * Remove extension parameter in the spec * Remove extension parameter from route of ListAsycOperations * Add Origin property to Available Operations response body * Make Identity property nullable * Add Get, List Extension Types (Azure#13562) * Add Get, List Extension Types * style check fixes * - update spec - rename and update example files - fix validation errors * fix examples * - update readme.md - generate example files with oav - try to fix some new validation errors * more validation fixes * add ExtensionTypeVersion_List * - update readme for SDKs - update examples * fix typo and linting * rename ExtensionTypeVersions_List * - address comments - update list extension versions based on location * fix list versions route * fix tag and unused parameters in spec file * fix autorest validatoin errors * udpate readme * update readme * try to fix sdk validation warnings * - prettier fix - revert changes to types.json * fix pageable missing itemName Co-authored-by: Carlo Cardella <[email protected]> Co-authored-by: chunyu3 <[email protected]>
Reverts #13709