Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Extensions Async API and other fixes" #13972

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Apr 16, 2021

Reverts #13709

@openapi-workflow-bot
Copy link

Hi, @chunyu3 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 16, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️❌LintDiff: 5 Errors, 3 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Extensions_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L38
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Extensions_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L97
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Extensions_Update' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L147
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'SourceControlConfigurations_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L38
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'SourceControlConfigurations_CreateOrUpdate' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L87
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create Extension
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L154
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Extension
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L213
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Source Control Configuration
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L209


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4017 - TopLevelResourcesListBySubscription The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it.
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L500
    R4017 - TopLevelResourcesListBySubscription The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it.
    Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L426
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L634
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L564
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.

    ️❌Cross Version BreakingChange (Base on stable version): 12 Errors, 0 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L290:3
    Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L290:3
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L329:5
    Old: common-types/resource-management/v2/types.json#L9:5
    1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L355:5
    Old: common-types/resource-management/v2/types.json#L82:5
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L348:9
    Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L506:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L295:9
    Old: common-types/resource-management/v2/types.json#L503:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L300:9
    Old: common-types/resource-management/v2/types.json#L507:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L305:9
    Old: common-types/resource-management/v2/types.json#L521:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L311:9
    Old: common-types/resource-management/v2/types.json#L526:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L316:9
    Old: common-types/resource-management/v2/types.json#L530:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L321:9
    Old: common-types/resource-management/v2/types.json#L544:9
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 16, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
    • ️✔️@azure/arm-kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
      cmderr	[npmPack] created ./dist/arm-kubernetesconfiguration.js in 215ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️kubernetesconfiguration [View full logs]  [Preview Schema Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-16 02:21:38 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-04-16 02:21:38 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-04-16 02:21:38 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration --java.namespace=com.azure.resourcemanager.kubernetesconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-kubernetesconfiguration
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Skip] pom already has module azure-resourcemanager-kubernetesconfiguration
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Skip] pom already has module sdk/kubernetesconfiguration
      cmderr	[generate.py] 2021-04-16 02:22:10 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-04-16 02:24:59 DEBUG Got artifact_id: azure-resourcemanager-kubernetesconfiguration
      cmderr	[Inst] 2021-04-16 02:24:59 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-16 02:24:59 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-04-16 02:24:59 DEBUG Match jar package: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-04-16 02:24:59 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13972/azure-sdk-for-java/azure-resourcemanager-kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar\" -o azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-kubernetesconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.SourceControlConfiguration [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️kubernetesconfiguration/mgmt/2021-03-01/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/kubernetesconfiguration/mgmt/2020-07-01-preview/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 519c136892a5e4b2f8c95471150f75c2a2aeb383. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-kubernetesconfiguration [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation SourceControlConfigurationsOperations.delete
      info	[Changelog]   - Added operation group ExtensionsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation SourceControlConfigurationsOperations.list has a new signature
      info	[Changelog]   - Operation SourceControlConfigurationsOperations.get has a new signature
      info	[Changelog]   - Operation SourceControlConfigurationsOperations.create_or_update has a new signature
      info	[Changelog]   - Operation Operations.list has a new signature
      info	[Changelog]   - Removed operation SourceControlConfigurationsOperations.begin_delete
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @chunyu3, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @chunyu3 chunyu3 merged commit f3dca56 into dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview Apr 16, 2021
    jianyexi pushed a commit that referenced this pull request May 19, 2021
    …5 01 preview (#14302)
    
    * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add Extensions Async API and other fixes (#13709)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Revert "Add Extensions Async API and other fixes (#13709)" (#13972)
    
    This reverts commit b78af6e.
    
    * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (#13992)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Remove extensions resource in the route of ListAsyncOperations at Cluster scope
    
    * Remove extension parameter in the spec
    
    * Remove extension parameter from route of ListAsycOperations
    
    * Add Origin property to Available Operations response body
    
    * Make Identity property nullable
    
    * Add Get, List Extension Types (#13562)
    
    * Add Get, List Extension Types
    
    * style check fixes
    
    * - update spec
    - rename and update example files
    - fix validation errors
    
    * fix examples
    
    * - update readme.md
    - generate example files with oav
    - try to fix some new validation errors
    
    * more validation fixes
    
    * add ExtensionTypeVersion_List
    
    * - update readme for SDKs
    - update examples
    
    * fix typo and linting
    
    * rename ExtensionTypeVersions_List
    
    * - address comments
    - update list extension versions based on location
    
    * fix list versions route
    
    * fix tag and unused parameters in spec file
    
    * fix autorest validatoin errors
    
    * udpate readme
    
    * update readme
    
    * try to fix sdk validation warnings
    
    * - prettier fix
    - revert changes to types.json
    
    * fix pageable missing itemName
    
    Co-authored-by: Carlo Cardella <[email protected]>
    Co-authored-by: chunyu3 <[email protected]>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …5 01 preview (Azure#14302)
    
    * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add Extensions Async API and other fixes (Azure#13709)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972)
    
    This reverts commit b78af6e.
    
    * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992)
    
    * Add Extensions Async API and other fixes
    
    * Re-add missed out changes
    
    * Fix validation errors, remove UpdateExtension.json
    
    * Update Readme.md
    
    * Add back files removed accidentally
    
    * Revert accidental changes & fix readme.md
    
    * Remove SourceControlConfig from this api version
    
    * Fix Readme.md error for go package
    
    * Fix Go readme issues
    
    * Fix Go readme issues - revert accidental change
    
    * Fix Go readme issues
    
    * Add kubernetesconfiguration GA version to this version Tag for SDK
    
    * Fix Operations api descriptions
    
    * Fix spelling mistakes
    
    * Update ApiVersionParameter reference in kubernetesconfiguration
    
    * Fix review suggestions
    
    * Add SourceControlConfiguration resourceType to this api-version
    
    * Updated readme files for the added SourceControlConfiguration resource type
    
    * Fix readme files to revert to previous + additions for new api-version
    
    * Consolidated common definitions to avoid duplication errors
    
    * Rename definitions folder - fix Avocado error
    
    * Consolidated common definitions reference
    
    * Fix definitions.json
    
    * Fix go readme
    
    * Remove extensions resource in the route of ListAsyncOperations at Cluster scope
    
    * Remove extension parameter in the spec
    
    * Remove extension parameter from route of ListAsycOperations
    
    * Add Origin property to Available Operations response body
    
    * Make Identity property nullable
    
    * Add Get, List Extension Types (Azure#13562)
    
    * Add Get, List Extension Types
    
    * style check fixes
    
    * - update spec
    - rename and update example files
    - fix validation errors
    
    * fix examples
    
    * - update readme.md
    - generate example files with oav
    - try to fix some new validation errors
    
    * more validation fixes
    
    * add ExtensionTypeVersion_List
    
    * - update readme for SDKs
    - update examples
    
    * fix typo and linting
    
    * rename ExtensionTypeVersions_List
    
    * - address comments
    - update list extension versions based on location
    
    * fix list versions route
    
    * fix tag and unused parameters in spec file
    
    * fix autorest validatoin errors
    
    * udpate readme
    
    * update readme
    
    * try to fix sdk validation warnings
    
    * - prettier fix
    - revert changes to types.json
    
    * fix pageable missing itemName
    
    Co-authored-by: Carlo Cardella <[email protected]>
    Co-authored-by: chunyu3 <[email protected]>
    @JackTn JackTn deleted the revert-13709-dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview branch August 17, 2021 08:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants