add AVS 2021-06-01 API #14215
add AVS 2021-06-01 API #14215
Conversation
ctaggart
requested review from
00Kai0,
ArcturusZhang,
jsntcy,
msyyc,
RAY-316 and
zhangyan133
as code owners
Swagger Validation Report
|
|
Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
|
I'm moving this to draft for a few days until we have complete test coverage of the API spec through the Azure SDK for .NET at Azure/azure-sdk-for-net#20836. |
|
@ctaggart please let me know when this is ready to review, thank you! |
|
Hey @ArcturusZhang, this is ready for review. We've completed our test coverage. |
Co-authored-by: David Becher <[email protected]>
ArcturusZhang
added
WaitForARMFeedback
|
We have gotten the ARM's sign off in https://github.com/Azure/azure-rest-api-specs-pr/pull/3018 |
* add AVS 2021-06-01 API * add cmdlets custom word * rename ScriptCmdlet cmdletDescription to description (Azure#14218) * Adding optional to the script parameter (Azure#14437) Co-authored-by: David Becher <[email protected]> Co-authored-by: david becher <[email protected]> Co-authored-by: David Becher <[email protected]>
This is a new Microsoft.AVS API version. It is a copy of what was last internally reviewed here.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.