Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.IoTCentral/iotApps] Removal of legacy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 #14311

Merged

Conversation

poanchen
Copy link
Member

@poanchen poanchen commented May 7, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @poanchen Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 7, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L603
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L644
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'apptemplates' in:'Apps_ListTemplates'. Consider updating the operationId
    Location: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L419
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 11 Errors, 2 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:
    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) 'F1, S1' from the old version.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L540:9
    Old: Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json#L523:9


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.IoTCentral/IoTApps/{resourceName}' removed or restructured?
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.IoTCentral/IoTApps' removed or restructured?
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L238:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.IoTCentral/IoTApps' removed or restructured?
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L278:5
    1019 - RemovedEnumValue The new version is removing enum value(s) 'F1, S1' from the old version.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L540:9
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L439:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L802:9
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L670:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L647:7
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L541:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L647:7
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L541:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L647:7
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L541:7
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L501:9
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L415:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L505:9
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L420:9
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L359:13
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L359:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L482:13
    Old: Microsoft.IoTCentral/preview/2017-07-01-privatepreview/iotcentral.json#L396:13
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"iotcentral/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 7, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - iotcentral/mgmt/2018-09-01/iotcentral - v55.5.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-iotcentral - 9.0.0b1
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0d3b1a8. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/iotcentral/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.IotCentral [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0d3b1a8. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-iotcentral [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model App has a new parameter state
      info	[Changelog]   - Model AppPatch has a new parameter state
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0d3b1a8. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-14 02:55:30 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-iotcentral;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-14 02:55:30 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-09-14 02:55:30 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/iotcentral/azure-resourcemanager-iotcentral --java.namespace=com.azure.resourcemanager.iotcentral   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/iotcentral/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-iotcentral
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Skip] pom already has module azure-resourcemanager-iotcentral
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Skip] pom already has module sdk/iotcentral
      cmderr	[generate.py] 2021-09-14 02:55:59 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-iotcentral [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-09-14 02:57:49 DEBUG Got artifact_id: azure-resourcemanager-iotcentral
      cmderr	[Inst] 2021-09-14 02:57:49 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-14 02:57:49 DEBUG Got artifact: azure-resourcemanager-iotcentral-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-14 02:57:49 DEBUG Match jar package: azure-resourcemanager-iotcentral-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-09-14 02:57:49 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14311/azure-sdk-for-java/azure-resourcemanager-iotcentral/azure-resourcemanager-iotcentral-1.0.0-beta.2.jar\" -o azure-resourcemanager-iotcentral-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-iotcentral -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-iotcentral-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0d3b1a8. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️iotcentral/mgmt/2018-09-01/iotcentral [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0d3b1a8. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/iotcentral/resource-manager/readme.md
    • ️✔️@azure/arm-iotcentral [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/iotCentralClient.js → ./dist/arm-iotcentral.js...
      cmderr	[npmPack] created ./dist/arm-iotcentral.js in 228ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0d3b1a8. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️iotcentral [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @poanchen poanchen added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 7, 2021
    @openapi-workflow-bot
    Copy link

    Hi @poanchen, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @poanchen poanchen changed the title Dev iotcentral microsoft.io t central 2021 06 01 [Azure IoT Central] Removal of legacy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 May 13, 2021
    @poanchen
    Copy link
    Member Author

    poanchen commented Aug 3, 2021

    @erich-wang please let us know if you have any feedback to this PR. Our code changes + arm manifest is already in prod. We have also tested the newly generated SDK against both canary + prod. So we should be good to merge this swagger changes to add a new RP api version 2021-06-01. As we will have other changes coming later on, we will not trigger an update to SDK until down the road. Thanks.

    @poanchen
    Copy link
    Member Author

    poanchen commented Aug 9, 2021

    @akning-ms please let us know how we can move forward and close this PR thanks

    @openapi-workflow-bot
    Copy link

    Hi @poanchen, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @akning-ms
    Copy link
    Contributor

    @akning-ms please let us know how we can move forward and close this PR thanks

    Hi @poanchen, Your PR is not ready for merge on below point:

    1. ARM sign off refer to: ARM API Review Checklist in first comment
    2. Breaking change review board approval, refer to: [Microsoft.IoTCentral/iotApps] Removal of legacy S1 SKU, S360 Fixes, newer RP API version 2021-06-01 #14311 (comment)
      due to below:

    ❌ 1019 - RemovedEnumValue | The new version is removing enum value(s) 'F1, S1' from the old version.
    New: Microsoft.IoTCentral/stable/2021-06-01/iotcentral.json#L540:9
    Old: Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json#L523:9

    @jorgecotillo
    Copy link
    Contributor

    Let us know if this PR still needs some feedback, it's been open for quite some time

    @poanchen
    Copy link
    Member Author

    @jorgecotillo We are in the process of getting our breaking changes approved by the ARM team. Will reach out once that is approved and we should be able to merge this.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 25, 2021
    @poanchen
    Copy link
    Member Author

    @jorgecotillo @akning-ms

    Breaking changes already got approved. Please merge this PR whenever you guys see this. Thanks tons!

    @poanchen
    Copy link
    Member Author

    poanchen commented Sep 2, 2021

    ping again here
    @jorgecotillo @akning-ms

    let me us know what else we need to do thanks!

    @akning-ms
    Copy link
    Contributor

    akning-ms commented Sep 3, 2021

    Hi @poanchen, you may need ping ARM on call person to review if urgent as below guideline:
    If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

    And can we know whether this version for your service end will be deployed on PROD

    @poanchen
    Copy link
    Member Author

    poanchen commented Sep 7, 2021

    @jorgecotillo @akning-ms

    We don't have urgency to merge this PR but we do want to get this PR moving forward. Please take a look when you guys have time. Thanks!

    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2021
    @poanchen
    Copy link
    Member Author

    poanchen commented Sep 13, 2021

    @jorgecotillo @akning-ms

    Now that we also got the ARM team approval. Can we move this forward? and merge this PR thanks!

    @akning-ms akning-ms merged commit 0d3b1a8 into Azure:main Sep 14, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 14, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …newer RP API version 2021-06-01 (Azure#14311)
    
    * Adds base for updating Microsoft.IoTCentral from version stable/2018-09-01 to version 2021-06-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * remove legacy sku S1
    
    * update template in example to use M3 template name
    
    * add suppress for R4009 and R3018
    
    * add state
    
    * update
    
    * should be read only
    
    * update example
    
    * Update iotcentral.json
    
    temporary changing this for further testing in canary.
    
    * removal of f1 and deleted state
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants