Adding APIs for the new resource - Network Security Perimeter (NSP) #14433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @harics24 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a different type 'object' than the previous one ''. New: Microsoft.Network/preview/2021-03-01-preview/network.json#L171:5 Old: Microsoft.Network/preview/2021-02-01-preview/network.json#L171:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 3 Errors, 5 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:3883" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:3887" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Error: Plugin prechecker reported failure." |
| "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from NetworkSecurityPerimeter" |
|
| "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from NetworkSecurityPerimeter" |
|
| "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from NetworkSecurityPerimeter" |
|
| "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink" |
|
| "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration" |
|
| 💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-03-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
Swagger Generation Artifacts
|
|
Hi, @harics24 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced May 17, 2021
|
Hi, @harics24 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @kairu-ms |
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { |
There was a problem hiding this comment.
Removed everywhere after discussing internally.
jorgecotillo
added
ARMSignedOff
26 tasks
|
NewApiVersionRequired reason: |
|
The error is pointing to this file: The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateLinkServices/{serviceName}/privateLinkResources is missing. I did not make any changes there. We do not own this service/endpoint. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 21, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @harics24. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
lirenhe
added
Approved-LintDiff
and removed
Reviewed-ChangesRequested
|
All lint errors are not related to this PR, approved for Lint. |
lirenhe
approved these changes
Jul 15, 2021
This was referenced Jul 15, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…zure#14433) * Defining the new resource NSP and the APIs * Adding the tag in get to be consistent with the list * Removing etags everywhere as per internal discussion * Creating a new folder for a new preview version Adding NSP resource changes * Changing version in all the files * Update readme.md * Removing the changes in the old version * Removing the network manager files Planning to use this version just for NSP and related resources. NM won't work with this version. * Update readme.md * Update readme.md * Fixing cross version breaking change * Removing the required fields in the correct version Update network.json * Attempting to fix the lint errors * Adding the type as object to fix lint errors Co-authored-by: Hari Prasad Perabattula <[email protected]>
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.